pass target arch to final image builder as TARGETARCH; use TARGETARCH… #3951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when generating raw and iso, fallback to build arch; use updated images that read TARGETARCH; ensure grub has EFI for all archs
- What I did
Fixes #3949
When you build for an EFI format for an arch different than the build arch, ensure you get the right .EFI file.
To enable it, it needs to:
outputImg()
andoutputIso()
, which pass them todockerRun()
, which passes them via-e
to the docker imagegrub
into 2 packages:grub-dev
andgrub
. It is really hard to cross-build grub's.EFI
files. Well, it is easy, but you need the modules, which is not so easy, so it was easier to buildgrub-dev
as images on each target platform and thengrub
just takes the output.EFI
from each- How I did it
Changed lots of files, see description above
- How to verify it
CI. Plus I ran local and cross-builds, and they all work correctly.
- Description for the changelog
Handle EFI bootable images for cross-builds