when pulling image to cache, if it is missing target arch, indicate an error #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n error Signed-off-by: Avi Deitcher <avi@deitcher.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When looking for a ref and specific arch in the cache, if it is missing entirely or incomplete for the target platform, it does an
ImagePull(). If that finds an index, it pulls it and, if successfully pulls, returns OK... without first checking if that index contains the target arch. So the caller thinks it found it locally, when it really didn't.This fixes it.
- How I did it
Added a check post-index-pull.
- How to verify it
CI and I checked manually.
- Description for the changelog
Handle pull image is missing target architecture