Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened the text a bit #4397

Closed
wants to merge 1 commit into from
Closed

Shortened the text a bit #4397

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2015

No description provided.

@clefebvre
Copy link
Member

Hi,

Can you provide a screenshot showing why it's too large?

@ghost
Copy link
Author

ghost commented Jul 5, 2015

Sure, here's a before/after.

Looks a bit more in proportion with the rest of the applets, in my opinion of course.

before
after

@tomoe-musashi
Copy link

i don't agree this commit.
"until full" and "Discharging" are pretty weird in this case.
also, i think it's better to show actual words like "hours" and "minutes".
it's confuse if it just show a string...

@clefebvre
Copy link
Member

Hi,

I left this PR opened for a while. I have to admit I've been hesitating.. there's pros and cons.. it does make things more concise on the one hand, but also harder to translate and slightly less explicit on the other hand.

The width of the applet, although large, isn't problematic as such, at least not to the point where it can only be considered a bug.

In the end I decided to leave things as they were then, and I'm closing this PR. I'd like to thank @lcafaro for his work on this. This didn't make it in, but we do appreciate every bit of help we can get.

@clefebvre clefebvre closed this Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants