Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the boxpointer from popup menus #5755

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

collinss
Copy link
Member

@collinss collinss commented Oct 3, 2016

No description provided.

@clefebvre
Copy link
Member

Hi,

A couple of points:

  • I'm really excited about this. I don't think it looks good yet, but I'm pretty sure I'll end up loving it when it's ready.
  • The animation is way too slow, it's frustrating to wait that long.
  • The position of the menu after the animation is finished must be wrong, because the fonts looks blurry/aliased/blueish/pinkish. Make sure you round the coordinates after applying Maths to them.
  • The menu applet uses its own trick or way to show its menu... I'm not sure how best to fix that, but whereas it looked somewhat ok before, with this PR it now looks drastically different when you open the menu and when you open other applets.
  • do we want a little gap? do we need rounding on the part touching the panel? how about borders? I'd run that with Joseph or artists, I'm not too sure myself but I think it could look better.

@clefebvre
Copy link
Member

Can we wrap the top widget into a container styled with boxpointer style class? I'm worried we're breaking all themes significantly here otherwise (making all their applets transparent basically).

@collinss collinss force-pushed the boxpointer-menu-remove branch 3 times, most recently from 0c4a9cf to 9a368aa Compare October 18, 2016 02:55
@collinss collinss changed the title [WIP] Remove the boxpointer from popup menus Remove the boxpointer from popup menus Oct 18, 2016
@clefebvre clefebvre merged commit d49dc4d into linuxmint:master Oct 25, 2016
@collinss collinss deleted the boxpointer-menu-remove branch October 25, 2016 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants