Add a script to install 3rd party spices from a local folder. This is… #7420
Conversation
… meant to be a helper script to aid in applet development.
collinss
force-pushed
the
install-xlet-script-add
branch
from
4819a2f
to
168d23c
Compare
files/usr/bin/cinnamon-install-spice
Outdated
| quit() | ||
|
|
||
| if spice_type is 'theme': | ||
| theme_file = os.path.join(source_dir, 'Cinnamon/cinnamon.css') |
There was a problem hiding this comment.
Shouldn't this be cinnamon/cinnamon.css all in lower case?
There was a problem hiding this comment.
Oh yeah, probably. I wrote this pretty late last night, and haven't really done a lot of testing yet (part of the reason it's labeled WIP :) ). I'll fix it later when I get the chance.
collinss
changed the title
| import argparse | ||
|
|
||
| import gi | ||
| gi.require_version('Gtk', '3.0') |
There was a problem hiding this comment.
You don't seem to be using the gi import in this file.
There was a problem hiding this comment.
Those lines prevent a warning when Spices.py is imported.
There was a problem hiding this comment.
I see, then, shouldn't these lines be added to Spices.py?
There was a problem hiding this comment.
Probably. They weren't there before because Spices.py was always only imported from cinnamon-settings, which already had those lines. Another option could be to see if we can refactor it so that we don't need to use Gtk as an import in Spices.py.
linuxmint#7420) * Add a script to install 3rd party spices from a local folder. This is meant to be a helper script to aid in applet development. * Spices.py: only show an update if the current version is less than the available one * cinnamon-install-spice: fix typo * Add argument parsing and usage to the xlet install script, and fix some bugs
… meant to be a helper script to aid in applet development.