Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather@mockturtl Missing localization on some headline titles in Config #3257

Closed
jorgenqv opened this issue Oct 11, 2020 · 1 comment · Fixed by #3264
Closed

weather@mockturtl Missing localization on some headline titles in Config #3257

jorgenqv opened this issue Oct 11, 2020 · 1 comment · Fixed by #3264

Comments

@jorgenqv
Copy link
Contributor

 * Applet version/Build date 2.6.6 Oct 10, 2020
 * Cinnamon version 4.6.7
 * Distribution - Manjaro Cinnamon 20.1.1
 * Graphics hardware *and* driver used - Intel Haswell-ULT Integrated Graphics Controller (i915)  

Notify author of applet
@Gr3q

Thank you for making a very usable, stable, feature rich and well working applet! Here is a minor observation for future updates:

Issue
Some of the Weather Configuration headlines is not translated from English to your choosen language: "Weather conditions", "Panel (Taskbar)", "Popup menu" and "Keybindings".

Steps to reproduce
Right click on the Weather Applet in panel and choose Configure, logged in using any language not English.

Expected behaviour
That all text in the Weather applet is translated to your choosen login language.

Other information
Edit and change:
#. settings-schema.json->conditionSettings->description
msgid "Weather Conditions"
To:
msgid "Weather conditions"
and Add:
#. settings-schema.json->presentationPanel->description
msgid "Panel (Taskbar)"
msgstr "...translation..."
#. settings-schema.json->presentationPopup->description
msgid "Popup menu"
msgstr "...translation..."
#. settings-schema.json->unitsIconsKeysKeybindings->description
msgid "Keybindings"
msgstr "...translation..."

@Gr3q
Copy link
Contributor

Gr3q commented Oct 13, 2020

You are absolutely right, they are not included in the .pot file.

It seems the cinnamon-spices-makepot script does not include section titles when it generates them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants