Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple-system-monitor@ariel: curious default width in Cinnamon 5.8+ #1085

Closed
schorschii opened this issue Mar 12, 2024 · 4 comments · Fixed by #1157
Closed

simple-system-monitor@ariel: curious default width in Cinnamon 5.8+ #1085

schorschii opened this issue Mar 12, 2024 · 4 comments · Fixed by #1157
Assignees
Labels

Comments

@schorschii
Copy link
Contributor

schorschii commented Mar 12, 2024

Desklet version/Build date

1.2.0

Cinnamon version

5.8+

Distribution

Mint 21.3

Graphics hardware and driver used

NVIDIA with proprietary driver

Desklet name and maintainer

simple-system-monitor@ariel @arielandrade

What happened?

Your desklet contains a version switch which introduced a default width of 300px in Cinnamon >=5.8. This leads to a big empty space on the right side:
image

On previous Cinnamon versions, the width was not set manually but determined automatically, which is more meaningful in my opinion. Can we bring the auto width back to 5.8+ or was this change really intentional?

Other information

No response

@schorschii schorschii added the bug label Mar 12, 2024
@rcalixte
Copy link
Member

rcalixte commented Mar 13, 2024

The issue is that the width is fixed in pixels but the font size is set by scale so there isn't a way to match the two on every system dynamically. The intention would be for users to configure it when first adding it but we could do something like double the default scale too. The reason the width was added was to prevent the variable nature of the values from constantly resizing the desklet as well.

My only concern is resetting the default value and how that could possibly affect existing installations. I believe it shouldn't impact any configured instances but unconfigured instances would be impacted. We could do a folder version bump to something like 6.2 and update the default size there. It would still impact users upgrading to 6.2 but at least clean installations would be unbothered going forward. I'm also open to any alternative ideas as well.

@rcalixte rcalixte self-assigned this Mar 13, 2024
rcalixte added a commit to rcalixte/cinnamon-spices-desklets that referenced this issue May 7, 2024
* Update default scale
* Update translation templates
* Close linuxmint#1085
rcalixte added a commit to rcalixte/cinnamon-spices-desklets that referenced this issue May 7, 2024
* Update default scale
* Update translation templates
* Close linuxmint#1085
rcalixte added a commit that referenced this issue May 7, 2024
* Update default scale
* Update translation templates
* Close #1085
@rcalixte
Copy link
Member

rcalixte commented May 7, 2024

Apologies for the delay on this. I was mistaken on the default value and what changing it would impact. It is safe to update with no impact to existing installations. Hopefully this is a better default. Sorry again for the delay on this!

@schorschii
Copy link
Contributor Author

schorschii commented May 7, 2024

No problem, thanks for addressing this now. Unfortunately I have to say that there is no difference in the current version when using font scale value 1.0 (the big empty space on the right side is still there).

@rcalixte
Copy link
Member

rcalixte commented May 8, 2024

Unfortunately I have to say that there is no difference in the current version when using font scale value 1.0 (the big empty space on the right side is still there).

Ah, sorry for the confusion there. There is still the issue of the dynamic width being too distracting. Unless we restrict font choices to monospace fonts and give the desklet a fixed character length, this would be the only way I can think of for the static width to work. Would it be better to align the desklet in the center of the defined width as a workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants