Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19.2 workspace-switcher does not display visual window indicators on small panels #8755

Closed
Nebelkind opened this issue Aug 3, 2019 · 4 comments · Fixed by #8757
Closed

Comments

@Nebelkind
Copy link

  Cinnamon version  4.2.3
  Distribution Mint 19.2
  64 bit

Issue
As of the 19.2 update the cinnamon workspace-switcher in the panel does not show visual representations of the opened windows anymore if the panel size is lower then 26px but displays the only the number of the workspace instead (removing and re-adding the applet results in a "something went wrong" warning in these situations)

Steps to reproduce
Set panel height to somewhere between 20px-25px,
Configure workspace switcher to show visual window representations,
Look at the workspace-switcher applet on the panel
Remove and afterwards add the applet to the panel to see the warning

Expected behaviour
One would expect the visual window representations to work down to the smalest offered Panel size of 20px (like in 19.1 and before)

@brownsr
Copy link
Member

brownsr commented Aug 3, 2019

It's by design in a recent change, so not a fault. It cuts over to numbers when the graph shown is judged too small to be useful. However I can see you might find the cutover point a little early, so I will experiment to see if a change would help.

Regards

Simon

brownsr added a commit to brownsr/Cinnamon that referenced this issue Aug 3, 2019
the graph is actually visible and usable to some degree right down to the smallest panel size that can be set
so there is no reason to switch over to buttons, which has confused at least one user.  Removing the tests
simplifies things.
fixes linuxmint#8755
@Nebelkind
Copy link
Author

Thanks for looking into it. Had been using it on 23px panel height for quite some time and never felt it lacking. Main usefulness for me always was that it reminds me I have windows open on this or that workspace with a single glance and the numbers unfortunately do not help there.

@gerard87
Copy link

gerard87 commented Aug 3, 2019

Same here, i'm using size 24 with a 1680x1050 resolution monitor and visual representation is perfectly functional and useful. Now it force me to choose between increase the size to 26 or loose the feaure. So, +1 to see the feature come back again, thanks.

@radiolabworks
Copy link

+1 here too. I updated four systems to 19.2 and lost the visual on three of them. Some were at 25 and needed to be set to 26 after reading this. A note would have been most useful on the configure window for the switcher that indicates a size 26 or greater is required to allow displaying of the visual representations in the Panel Configuration. I would opt for returning it back as my original setting were useful at 25 for sure.

clefebvre pushed a commit that referenced this issue Sep 20, 2019
the graph is actually visible and usable to some degree right down to the smallest panel size that can be set
so there is no reason to switch over to buttons, which has confused at least one user.  Removing the tests
simplifies things.
fixes #8755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants