Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom keyboard shortcuts don't work until logout #9375

Closed
dpirch opened this issue Jun 15, 2020 · 2 comments
Closed

custom keyboard shortcuts don't work until logout #9375

dpirch opened this issue Jun 15, 2020 · 2 comments

Comments

@dpirch
Copy link

dpirch commented Jun 15, 2020 •
edited 

 * Cinnamon 4.6.3 (from ppa) (same issue with 4.4.8 from ubuntu 20.04)
 * Ubuntu 20.04
 * Mesa DRI Intel(R) HD Graphics 4600 (HSW GT2)
 * 64 bit

Issue
When adding custom keyboard shortcuts or editing existing ones (either command or shortcut), the change does not become active immediately, but only after logging out and in again.

Steps to reproduce

  • run cinnamon-settings, go to Keyboard > Shortcuts > Custom Shortcuts
  • click "Add custom shortcut", type e.g. Name: "test", Command: "gedit", click "Add"
  • assign keybinding by clicking on an "unassigned" row, press e.g. Super+F8, close window

Expected behaviour
the shortcut is active immediately, i.e. pressing Super+F8 launches gedit

Actual behaviour
the shortcut does not work - it only works after the next login.

Other information
Keyboard shortcuts other than custom shortcuts are apparently updated immediately.
@mtwebster
Copy link
Member

As a workaround until this is fixed, you can restart cinnamon to update the shortcuts (it's quicker than logging out) - alt-f2, then type r in the box, and enter.

@mtwebster
Copy link
Member

Fixed in current release: 4531ff5

mtwebster added a commit that referenced this issue Jul 12, 2020
@mtwebster
keybindings: revisit #9375, keybindings not updating.
31314e2 
See comments in code.  When the 'custom-list' contains only a single
entry, reversing that list will not trigger the 'changed' notification
that keybindings.js listens to.

Make sure there are always at least two entries in the list by adding
a dummy string.

Steps to reproduce (post-#9375):

- Start with no custom shortcuts.
- Add a custom shortcut (custom-list now contains 'custom0').
- Assign a keybinding to that shortcut.  (custom-list still only
  contains 'custom0', and reversing it fails to trigger any change.
- Add second shortcut - issue disappears, as there are two elements
  to reverse order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtwebster @dpirch