Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of pull requests for testing purposes #1076

Merged
merged 27 commits into from
Sep 5, 2012

Conversation

mtwebster
Copy link
Member

I've made a branch that merges all commits from the following pull requests:
#973
#1021
#1023
#1035
#1040
#1051
#1059
#1062
#1066
#1067

This is for the convenience of testing out these changes without having to immediately worry about merge conflicts (which definitely occur between all of these) - let me know your decisions and I can make the needed changes or removals.

full power of a file picker, copy/paste, and icon previews
For instance, if you have a checkbox A, and you want combobox B and C
to be disabled if checkbox A is unchecked, you would pass the
schema/key combination for checkbox A along with the other construction
arguments for B and C.  If there is no dependency, pass None in its place.

Currently only supporting checkbox dependencies - anything more complicated
and it needs its own handling.

You can also invert the dependency by adding a ! in front of the
whole schema/key string.  In the above example, if inverted, if checkbox A is
UNCHECKED, combobox B and C WILL be enabled, and disabled if checkbox A
is CHECKED.

Argument structure:
[!]<dependency-schema>/<dependency-key>
(window list applet).

Also shorten transition duration for focused window so it won't
lag behind so much.
…stom

panel heights.

Note any existing applets that wish to take advantage of this will require
adding panel_height to their main, and myapplet init code - I've updated all
prepackaged applets, so they can be used as an example.

Any applets that use Applet.IconApplet, Applet.TextApplet, or Applet.TextIconApplet
will automatically resize themselves when the option is on.  Applet.Applet applets
will need to add an on_panel_height_changed function in their MyApplet prototype
to take care of any resizing necessary.
… is removed

- Shuffled code around in applet
- Added '_destroy' method to applets, that is called from appletManager
  allows applet to perform some cleanup before it's removed from the stage.
- Some cleanup in appletManager
- Remove unneeded signal methods
- Replace heavily used anon functions
- Improve method of sorting through hide/show of apps
menu 'open-state-changed'.  Also, added a short-circuit 'text-changed'
callback, which was getting fired when the search box was given focus.
Remove some unused css tags.
Fixed a CSS issue that was causing some ghosting when using mouse
and keyboard navigation simultaneously.
that is not needed (originally changed from % to px to remove log
errors)
… it.

Causes problems on some distros - thanks to @vovka-korovka for finding this.
- Show absolute path of places/bookmarks in selected app description.
- Implement enter/return to open functionality with places and recents.

Also, increased recent files shown to 20, and unburied the value in case
we want to change it later.
@dalcde
Copy link
Contributor

dalcde commented Sep 4, 2012

It would be nice if you could add descriptions of each pull request you've included here. It would save us from clicking all the links.

@mtwebster
Copy link
Member Author

Can just use this link:

https://github.com/linuxmint/Cinnamon/pulls/mtwebster

The only pull request not included in this (other than self) is #1069 (Add missing dependency for background picker tool.)

@clefebvre
Copy link
Member

oh wow... :)

ok, first thanks for doing that. It's a big chunk to look into but it makes things easier to test, definitely.

@mtwebster
Copy link
Member Author

Issues addressed/closes:

#973
#1021
#1023
#1035
#1040
#1051
#1059
#1062
#1066
#1067
#133
#563
#507

clefebvre added a commit that referenced this pull request Sep 5, 2012
Rollup of pull requests for testing purposes
@clefebvre clefebvre merged commit b79ae47 into linuxmint:master Sep 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants