Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to replace the Gnome-Control-Center keyboard page #1224

Merged
merged 4 commits into from
Oct 18, 2012

Conversation

mtwebster
Copy link
Member

...with settings that actually work.

All functionality should be duplicated here, with the additional advantage
of being able to assign multiple bindings to items that support it.

To do possibly before merge:

  • Add any keys I may have missed or felt didn't need to be in there

Addresses:
#1117
#797
#1174
#722
#713
#544
#974
#549

@ScipioAfricanus
Copy link

@mtwebster
Great work!
I think "Toggle Overview" and "Toggle Expo" are mistakenly switched.
Btw, shouldn't it be "Toggle Scale" instead of "Toggle Overview"?

Thanks for this great feature.

@mtwebster
Copy link
Member Author

One issue I see - we have a number of bindings hardcoded in Cinnamon - Alt-tab, Shift-alt-tab, alt-f2 to name a couple. I haven't looked into changing those, but I will. It can only cause confusion if someone assigns one of these 'special' bindings to something else, and it doesn't work.

@ScipioAfricanus
Copy link

I think an option to reset each setting (individually) to its default value would be very useful.

@mtwebster
Copy link
Member Author

Moved bindings to the top for easier access, added right-click reset-to-defaults context menu.

And squashed commits

@mtwebster mtwebster closed this Oct 12, 2012
@mtwebster mtwebster reopened this Oct 12, 2012
mtwebster added a commit to mtwebster/Cinnamon that referenced this pull request Oct 14, 2012
@AlbertJP
Copy link
Contributor

@mtwebster Which one do we need, #1264 or this one? Please close one of them.

…ngs that

actually work.

All functionality should be duplicated here, with the additional advantage
of being able to assign multiple bindings to items that support it.
This isn't 100% reliable - you have to get the key press duration just
so for it to take, but with a couple tries you can do it.

Added menu popup keybinding also.
@mtwebster
Copy link
Member Author

I guess this one - the other will have to wait, since it breaks every time someone makes a change to cinnamon-settings.

clefebvre added a commit that referenced this pull request Oct 18, 2012
Attempt to replace the Gnome-Control-Center keyboard page
@clefebvre clefebvre merged commit abe460b into linuxmint:master Oct 18, 2012
@ScottGarman
Copy link

Thank you for fixing this - I am so much happier now using Cinnamon. It's a great desktop environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants