Commits on Nov 22, 2019

1. fix regression in ExtensionCore not working when updates are available …

   In commit 6ac295a,
   Settings>Applets>Download gained the ability to display the number of
   available updates, using an ngettext-translated message. However, it has
   never worked since ngettext was never imported in the file in question,
   so it simply raised a traceback.
   
   In the same commit, gettext.install() was taught to declare
   names="ngettext", but as per the python documentation, the names=
   argument requires a sequence (of one or more aliases to declare in the
   global namespace), not a string. So it tried to check if it could
   install the gettext functions: {'x', 't', 'e', 'g'}, which was wrong.
   
   The fix is to either import ngettext directly, so it can be used as-is,
   or globally install ngettext by passing it as a one-item list to the
   gettext.install() function. I've done the latter.

   

   eli-schwartz committed Nov 22, 2019
   Copy the full SHA

   568064c View commit details

   Browse the repository at this point in the history