Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all monitor(s) geometry to determine hot corner positions (linuxmint#7726) #9550

Conversation

codewithmichael
Copy link

@codewithmichael codewithmichael commented Aug 30, 2020

Fixes #7726

Description:

Avoids hard-to-trigger "corner" points between monitors on dual/multi-monitor setups by moving hot corner positions to the outer edge.

Change Summary:

  • Updated the HotCornerManager.updatePosition() to (optionally) accept multiple monitors for use in determining hot corner positions.
  • Updated LayoutManager._updateBoxes() to pass all connected monitors instead of just primaryMonitor.

@mtwebster
Copy link
Member

Hi, there a few things here:

  • This would be a regression for people that might being using hot corners on shared edges of a multi-monitor setup.
  • There's an option for only showing a workspace overview (expo) that only displays the primary monitor - using a hot corner to activate this could be confusing with this option activated.

It's probably a fairly common case also, since the issue goes away with adjacent panels on adjacent monitors - barriers are added by default (panel settings->allow pointer to pass thru edges of panels).

These barriers are probably the best solution for the original problem - if an 'inner' corner is active, place a barrier there to keep the pointer from overshooting.

Maybe in a later patch multi-monitor support could be added (adding corners to more than the primary monitor).

The pointer barriers are not terribly complicated - it's implemented in cinnamon's panel.js file if you're interested in taking a look - if you'd like update this pr (or open a new one later).

Thanks

@mtwebster mtwebster closed this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants