Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display modes #5

Merged
merged 2 commits into from Apr 28, 2016
Merged

Display modes #5

merged 2 commits into from Apr 28, 2016

Conversation

Yanpas
Copy link
Contributor

@Yanpas Yanpas commented Apr 24, 2016

Screenshot:
_2016-04-24_17-13-14

Sources:
source.zip

@Yanpas
Copy link
Contributor Author

Yanpas commented Apr 25, 2016

I'm not sure whether dotted lines are good looking. BTW I absolutely don't mind editing my source files

@clefebvre
Copy link
Member

@Yanpas I think it looks nice. I'm not sure orange is the best highlighting color (I'm biaised, I usually prefer green or shades of grey :)).

@Yanpas
Copy link
Contributor Author

Yanpas commented Apr 27, 2016

@clefebvre I've updated both commits :) BTW github supports commit squashing, so I think it's ok that both my PR's contain two commits.

@clefebvre
Copy link
Member

Thanks @Yanpas

@clefebvre clefebvre merged commit 4a447a7 into linuxmint:master Apr 28, 2016
@clefebvre
Copy link
Member

@Yanpas it could be on my side, but I'm testing the theme with LO 5.1.2.2 in a Mint 18 ALPHA ISO here and none of the icons are loading.

@clefebvre
Copy link
Member

I see this when launching LO from terminal:

(soffice:16197): Gdk-WARNING **: gdk_window_set_icon_list: icons too large

(soffice:16197): Gdk-WARNING **: gdk_window_set_icon_list: icons too large

** (soffice:16197): WARNING **: Invalidate all children called

@Yanpas
Copy link
Contributor Author

Yanpas commented Apr 29, 2016

I get the same warnings on LM17.3 and LO 5.1.2, but everything works.
libreoffice-style-human package does not contain such icons.

Have you tested LO 5.1.x on LM17.x distro? I guess gtk update have broken something.

I've followed tango icons theme namings/conventions etc. I guess if Breeze and Tango icons do not work, then something wrong with LO/GTK. You may find them in ppa:libreoffice:
libreoffice-style-tango libreoffice-style-breeze

@Yanpas
Copy link
Contributor Author

Yanpas commented Apr 29, 2016

@clefebvre Images from your package do not work at all, cause you have placed them in images_human directory
_2016-04-29_19-58-01

I've repacked the archive and no everything works on Xubuntu 16.04
_2016-04-29_20-01-52

@clefebvre
Copy link
Member

ah.. I didn't see that when extracting it, well spotted.

I'll check the packaging to see why it's doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants