Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint-Y: Pale fullcolor action icons #197

Open
clefebvre opened this Issue Mar 6, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@clefebvre
Copy link
Member

clefebvre commented Mar 6, 2019

Problem

Some applications are still using fullcolor icons instead of symbolic icons. It's not reasonable to think we can patch them all. We ship three variations of Mint-Y themes:

  • Mint-Y uses light widgets and requires dark icons
  • Mint-Y-Dark uses dark widgets and requires light icons
  • Mint-Y-Darker uses both light and dark widgets and requires sometimes dark icons sometimes light ones.

As a compromise and to make icons visible on all themes, we currently ship with action fullcolor icons which are pale grey. The good news is that they're visible everywhere. The bad news is that they don't look good anywhere.

image 8

Ideally, in the picture above, the icons would be much darker on the light menu, and much lighter in the dark toolbar. This isn't possible with fullcolor icons though.

Solution 1 (Rejected)

Switch to a colourful set of fullcolor action icons.

Pros:

  • They'll likely look OK on any background.

Cons:

  • They'll look different than symbolic icons, bringing inconsistency and making apps using them integrate less in the desktop.
  • It's hard to find a good existing set out there.
  • Highlighting a colorful icon can be problematic depending on its color and the color of the theme. For instance if the theme is Mint-Y-Blue, highlighting a widget using a blue action button might hide the icon.

Solution 2 (Accepted)

  • Produce two sets of icons per color variation: one light (for -dark and -darker themes) and one dark (for light themes)
  • Switch Mint-Y-Darker GTK3 to use dark menus
  • Switch Mint-Y-Darker GTK2 to use dark menus

We could also disable icons in menus, but if people re-enabled them, Mint-Y-Darker would look broken.

Pros:

  • The icons will look good and similar to symbolic icons, giving apps a consistent look.

Cons:

  • With 33 GTK themes and 22 icon themes, Mint-Y is starting to be quite big.

Solution 3

  • Only ship one Mint-Y theme (light, green, with dark fullcolor icons), i.e. 1 GTK theme with 1 icon theme.
  • Ship a theme generator/customizer tool which can generate variations, in which the user selects an accent color, and a theme variation (Light, Dark, Darker), and which produces a custom theme for him/her.
  • Use the ideas from solution 2 (Making -Darker variation use dark menus and -Dark/-Darker variations use light fullcolor icons).

Pros:

  • Same as solution 2
  • Less duplication and mayhem in theme selection tools
  • More flexibility for users, the tool could even use sass and let them define some of the colours of the theme (other than just the accent colour).

Cons:

  • Users currently using colour variations would be using a theme which no longer exists when upgrading. They would end up with Adwaita temporarily.
  • The generation tool might have some limits when colorizing assets.

@clefebvre clefebvre changed the title Pale fullcolor action icons Mint-Y: Pale fullcolor action icons Mar 6, 2019

clefebvre added a commit that referenced this issue Mar 8, 2019

Mint-Y-Darker: Switch menus to dark
This reduces complexity and allows us to ship with clear icons.

The commit contributes to partly fixing #197.

clefebvre added a commit to linuxmint/mint-y-icons that referenced this issue Mar 9, 2019

Darken action icons from #6e6e6e to #404040
These icons were originally made as a compromise to be visible both in the
dark themes and the light one. This resulted in them being functional but
not looking good in any of the themes.

We're now moving towards different icon sets for dark and light themes, this commit
darkens the icons in the standard set to adapt better to the light theme.

See linuxmint/mint-themes#197
@clefebvre

This comment has been minimized.

Copy link
Member Author

clefebvre commented Mar 9, 2019

Solution 2 is implemented.

@clefebvre

This comment has been minimized.

Copy link
Member Author

clefebvre commented Apr 4, 2019

Reopening... mint-y-darker wasn't fully acceptable, still an issue in inkscape, printer queue dialog etc.. so menus are back in white again and we need to bring back pale grey icons, but only for -darker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.