Extensive improvement of GTK2/3 consistency. #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces all explicit color references (e.g. #FFFFFF) with versions derived from the theme colors specific in the relevant header files (settings.ini and gtkrc for 2/3 respectively). This opens the door for changing header colors and gettings appropriate changes throughout the theme.
Using Mint-X, the Google-Chrome window borders incorrectly picked up the theme_selected_bg_color, which makes them stand harshly against the window borders. This customization file corrects this to display as a matte-grey.
This is a new @define intended to be a shade of @theme_selected_bg_color to be used for controls which are not expected to display readable text in the selection area, and which can have a shade which would normally render text less legible.
This change re-centers the shades used in menubar and treeview items around the 1.0 mark, so that the overall effect remains the same but their color is directly determined by @theme_selected_bg_color.
This is the barest-essentials synchronization of the GTK2/3 button styles. It matches coloring, gradients, mouse-over effect and focus highlight effect.
This commit adds the barebones needed to achieve a synchronized look to the GtkProgressBar and Scale/Slider widgets. In particular, the progressbar is defaulted back to the classic "wide" look default for 2/3, though animation for it is removed since it's not currently clear how to achieve the same effect in both engines.
Background color of the menus is changed to be consistent with the white-look of GTK3. Removes the shade effects from GTK2 menu select coloring to bring them inline with the average effect acheived by the gradients in GTK3 (which is very subtle now).
This commit adds a few minor changes to bring the GTK2 entry boxes in coloring and style inline with GTK3 as much as possible. The bg[INSENSITIVE] color, and progress-border-widths are changed to match up.
This commit matches the rendered coloring of GTK treeviews between GTK2 and GTK3. The GTK3 column header element is also modified to match the GTK2/3 button-style and thus synchronize their coloring and appearance.
The edge gradient pixmap effect in GTK2 treeviews is removed. This effect was utterly inconsistent with the GTK3 theme, and integrated poorly with most applications.
The treeview expanders looked very "smudgy" in the current theme due to an imbalance of the grey colors around them. This commit removes the imbalance and replaces it with clean transparencies and sharp lines, greatly improving the overall appearance. The expander icon size property is changed to match the new expander icons in GTK2/3.
This commit synchronizes the look of the GTK2 notebook widget to GTK3 as much as possible. This switches the "pixmap" engine to "murrine", and matches the tab spacing and height between the two elements. There is a slight residual highlight effect left behind, but this is minimized. The removal of the pixmap engine solves a number of unsightly glitches throughout GTK2 applications when labels and other elements are superimposed.
Two minor property values in GTK3 are altered to match their GTK2 counter-parts. -GtkScrolledWindow-scrollbars-within-bevel: 0; -GtkToolbar-internal-padding: 1;
All text (normal and selected) is rendered as #2c2c2c. Restored the original selected_bg_color to #accd8a. Re-ordered "settings" lines for easier maintenance.
It introduces too many edge cases in theming GTK2.
Adds Eclipse project files to ignore (useful for Git merging).
|
As per @clefebvre request I've reformatted this pull into a much more logical commit series. The last patch is a revert of something I did early on in formatting the patch series since it adds a whole bunch more questions about how to do the GTK2 themeing then it really solved (and it was too tricky to pick out cleanly in a rebase). As per IRC discussions, I've also altered selected_fg_color definitions (in gtkrc and settings.ini headers) to use #2c2c2c as the selected text color, which allows the use of the lighter green overall (and I think, solves that whole problem rather well). |
|
Thanks :) |
The selected item is not reliably set in the Nemo sidebar, leading to a flicker. By forcing the selected color to be the same as the unselected foreground color, we fix this.
This theme change fixes the selected element being unreadable in the Nemo inactive pane by having it inherit normal selected item background color properties.
|
Since this is still pending, I've added some fixes for Nemo under the new scheme in Mint-X, and notably fixed the second pane producing unreadable or unclear highlighting. Dual-pane mode improvements (also visible, lighter inactive pane color - but its a separate commit): Drop shadow removed from sidebar: Note: 4a0c4a1 is a minor fix to deal with an oddity in how the Sidebar selection occurs, which causes it to "flicker" and change color (since it doesn't seem to reliably hold it's "selected" state at the moment). |
|
Closed pending a rework on review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly substantial overhaul of the GTK2 Mint-X theme to bring it much more into line with the look and feel of the GTK3 Mint-X theme. It matches colors and gradients between elements as closely as is possible.
It also includes:
* cleaned up expander icons for the treeview
* removes the pixmapping of GTK2 treeviews (which led to a dirty appearance which didn't work well in many applications)
* adds a chrome.rc override file for a consistent chrome look.
* GTK2 and 3 color schemes have been based on shades as much as possible, to allow the possibility of changing the entire theme's coloring from just the settings.ini and gtkrc.
Closes issue #12 and issue #13.
Sample of the new Chrome look:
Before changes (mint-themes currently):
BEFORE
After changes (this pull):
AFTER