Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Editing (add/remove) of favorites defined via desktop files in sub-directories broken #40

Closed
norbusan opened this issue Dec 20, 2020 · 7 comments

Comments

@norbusan
Copy link

Hi all

Debian maintainer here. We are running xapps 2.0.4 and I got a report that adding/removing favorites that are defined insub-directories of ~/.local/share/applications, that is like ~/.local/share/applications/foobar/myfavorite.desktop, does not work with the update to xapps v2 (report mentioned Cinnamon 4.8, but that was when we bumped to xapps 2).

According to the reported, they have seen this also on other (non-Debian) systems, so it seems to be an upstream issue.

@mtwebster
Copy link
Member

Do you mean the favorite apps down the left side of the menu applet?

@misterhsp
Copy link

Yes, that's who he means. I have informed him of this. The problem appeared with the release of Cinnamon 4.8. Before that everything was fine. Creating favorites from subdirectories ~/.local/share/applications/foo... does not work anymore. With Archlinux the problem also exists since Cinnamon 4.8.

...

@mtwebster mtwebster transferred this issue from linuxmint/xapp Dec 21, 2020
@mtwebster
Copy link
Member

This is caused by cinnamon-menus, not libxapp - upgrading it to 4.8.2 should resolve the issue.

ref: linuxmint/cinnamon-menus@43dd740

@misterhsp
Copy link

misterhsp commented Dec 21, 2020 via email

@misterhsp
Copy link

misterhsp commented Dec 29, 2020 via email

mtwebster added a commit to mtwebster/Cinnamon that referenced this issue Jan 1, 2021
key for the CinnamonAppSystem app table.

Some applets (menu, gwl and panel-launchers) want to use this id
for lookups at a later time. In the case of desktop files inside of
subfolders, cinnamon-menus prepends the parent path to the desktop
filename, and this is used as a key in CinnamonAppSys. This won't
match the id returned by g_app_info_get_id() causing app-sys lookups
to fail later on.

ref: linuxmint/mint20.1-beta#40
mtwebster added a commit to mtwebster/Cinnamon that referenced this issue Jan 1, 2021
key for the CinnamonAppSystem app table.

Some applets (menu, gwl and panel-launchers) want to use this id
for lookups at a later time. In the case of desktop files inside of
subfolders, cinnamon-menus prepends the parent path to the desktop
filename, and this is used as a key in CinnamonAppSys. This won't
match the id returned by g_app_info_get_id() causing app-sys lookups
to fail later on.

ref: linuxmint/mint20.1-beta#40
@mtwebster
Copy link
Member

Should be fixed by linuxmint/cinnamon#9817, pending confirmation.

@misterhsp
Copy link

misterhsp commented Jan 2, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants