Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

[Cinnamon] Xviewer disregards Plugin for "Disable Dark Theme" #72

Closed
Harry-W-Haines-III opened this issue Jul 16, 2022 · 9 comments
Closed
Labels
Fixed in Git Claimed fixed in git, but not yet confirmed.

Comments

@Harry-W-Haines-III
Copy link

Describe the bug
When you first set [x] Disable Dark Theme in Preferences | Plugins tab, the dark theme changes to light immediately when checked. Close Xviewer. Open another image in Xviewer, the theme is dark.

To Reproduce
Steps to reproduce the behavior:

  1. Open an image with Xviewer
  2. Go to Preferences
  3. Click on Plugins
  4. Check [x] Disable Dark Theme
  5. Theme immediately changes to light.
  6. Close Xviewer
  7. Open Xviewer again.
  8. Theme is dark but when you check Preferences | Plugins tab, [x] Disable Dark Theme is enabled.
  9. Issue is solid and repeatable.

Expected behavior
Expected Xviewer to maintain the light theme as selected.

Screenshots
Screenshot from 2022-07-16 16-00-48

Is your system all up-to-date ? Yes.

@JosephMcc
Copy link

It seems to be ignoring the setting when you relaunch. Not sure if this is actually a new issue or not.

@JosephMcc JosephMcc added the Bug (Confirmed) Something isn't working and devs can reproduce. label Jul 16, 2022
@JosephMcc
Copy link

JosephMcc commented Jul 17, 2022

This one is an easy fix.

apt install gir1.2-xviewer-3.0

That needs to be installed by default for the xviewer plugins to work.

@Harry-W-Haines-III
Copy link
Author

So this will be done on the ISO or we would need to do it manually after a fresh install?

@Harry-W-Haines-III
Copy link
Author

Confirmed when this extra specified package is loaded the issue is resolved.

@JosephMcc
Copy link

I'm unsure how the fix will be pushed out. Weather it will be done automatically by an update or some other means. I'm sure clem will let people know if they need to do something extra.

@Harry-W-Haines-III
Copy link
Author

Usually Clem would add the package to the ISO. You may close this item out. Thank you.

@JosephMcc
Copy link

We are mostly leaving these open until we have a confirmed fix. Helps to make sure we don't let one slip through the cracks.

@clefebvre
Copy link
Member

clefebvre commented Jul 18, 2022

Well, if the plugins don't work correctly without it, we can simply make it a dependency of xviewer-plugins.

mtwebster added a commit to linuxmint/xviewer-plugins that referenced this issue Jul 18, 2022
@mtwebster mtwebster added Fixed in Git Claimed fixed in git, but not yet confirmed. and removed Bug (Confirmed) Something isn't working and devs can reproduce. labels Jul 18, 2022
@Harry-W-Haines-III
Copy link
Author

Update manager pulled in and installed the gir1.2-xviewer-3.0 package. Issue was resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed in Git Claimed fixed in git, but not yet confirmed.
Development

No branches or pull requests

4 participants