Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init.d script and other stuff #15

Closed
wants to merge 4 commits into from
Closed

fix init.d script and other stuff #15

wants to merge 4 commits into from

Conversation

darealshinji
Copy link
Contributor

This pull request has less changes then #13

This will update the Debian files to the new debhelper format and it'll fix the following Lintian tags:

E: mintsystem source: source-contains-unsafe-symlink usr/bin/rtfm
W: mintsystem source: debian-rules-missing-recommended-target build-indep
W: mintsystem source: debian-rules-missing-recommended-target build-arch
W: mintsystem source: binary-arch-rules-but-pkg-is-arch-indep
W: mintsystem source: ancient-standards-version 3.7.2 (current is 3.9.5)
E: mintsystem: copyright-should-refer-to-common-license-file-for-gpl
W: mintsystem: copyright-without-copyright-notice
W: mintsystem: extended-description-line-too-long
E: mintsystem: file-in-usr-local usr/local/bin/mint-md5sum
W: mintsystem: file-in-unusual-dir usr/local/bin/mint-md5sum
E: mintsystem: prerm-calls-updaterc.d mintsystem
E: mintsystem: postrm-does-not-call-updaterc.d-for-init.d-script etc/init.d/mintsystem
E: mintsystem: init.d-script-does-not-implement-required-option etc/init.d/mintsystem start
E: mintsystem: init.d-script-does-not-implement-required-option etc/init.d/mintsystem stop
E: mintsystem: init.d-script-does-not-implement-required-option etc/init.d/mintsystem restart
E: mintsystem: init.d-script-does-not-implement-required-option etc/init.d/mintsystem force-reload
E: mintsystem: python-script-but-no-python-dep usr/lib/linuxmint/mintSystem/mint-adjust.py
E: mintsystem: python-script-but-no-python-dep usr/local/bin/apt
W: mintsystem: binary-without-manpage usr/bin/rtfm
W: mintsystem: executable-not-elf-or-script usr/local/bin/mint-md5sum
W: mintsystem: init.d-script-does-not-source-init-functions etc/init.d/mintsystem

The remaining files in /usr/local/bin should be moved to /usr/bin or to a different location outside of /usr/local and installed to /usr/local/bin via update-alternatives. But for this pull request I kept them where they are. Same for the stuff in /usr/lib.


override_dh_usrlocal:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed, when there are no more files in /usr/local

@monsta
Copy link
Contributor

monsta commented Aug 20, 2014

About including /lib/lsb/init-functions - what does that fix actually?

@darealshinji
Copy link
Contributor Author

@monsta
Copy link
Contributor

monsta commented Aug 20, 2014

No, I mean what errors or bugs does it fix?

@darealshinji
Copy link
Contributor Author

It fixes the init.d-script-does-not-source-init-functions warning in Lintian. If you think sourcing init-functions is pointless or might even break things, it should be removed and the Lintian tag should be overridden.
The main "fix" is actually that the script now supports the start|stop|status|restart|force-reload options.

@monsta
Copy link
Contributor

monsta commented Aug 21, 2014

I just thought it might help with fixing the ordering cycle issue, but turns out it's not... I've eventually fixed it another way (#16). Nevermind then.

@darealshinji
Copy link
Contributor Author

I made new and smaller pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants