Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build with slibtool. #577

Merged
merged 2 commits into from Feb 22, 2021
Merged

Fix the build with slibtool. #577

merged 2 commits into from Feb 22, 2021

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jan 26, 2021

When building muffin with slibtool (https://dev.midipix.org/cross/slibtool) it fails, this PR has two commits to fix the build.

  1. Several libtool .la files are missing as dependencies in some of the Makefile.am files.
  2. The build fails with -no-undefined, this works with GNU libtool because it silently ignores -no-undefined while slibtool does not. This requires building src/compositor/plugins separately from the rest of src/ to ensure libmuffin.la exists when it is needed.

Full logs:

muffin-slibtool.1.log
muffin-slibtool.2.log

@mtwebster
Copy link
Member

Thanks

@mtwebster mtwebster merged commit fbe82b4 into linuxmint:master Feb 22, 2021
@orbea orbea deleted the slibtool branch February 22, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants