Upstream regions fix, claims to solve linuxmint/Cinnamon#698 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't do anything with it other than modify an existing region. https://bugzilla.gnome.org/show_bug.cgi?id=677116
We shouldn't need to process it here. https://bugzilla.gnome.org/show_bug.cgi?id=677116
meta_window_group_paint tries to carefully figure out which parts of the scene it can avoid painting. One area it avoids painting is the region of the screen occupied by an unredirected window (if there's one present). In subtracting that region, it gets the coordinate spaces confused, and ends up subtracting the area at the wrong offset. This commit translates the region to the correct offset before subtracting. https://bugzilla.gnome.org/show_bug.cgi?id=677116
Credits to Michael Wisheu for bringing this to our attention.
clefebvre
added a commit
that referenced
this pull request
Jun 1, 2013
Upstream regions fix, claims to solve linuxmint/cinnamon#698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches is claimed to solve linuxmint/cinnamon#698, see linuxmint/cinnamon#698 (comment).
I have packaged the patch supplied by wisheu on top of the original upstream patches, for proper attribution.
As far as I can tell, from my limited testing, this seems to solve the issue on my setup (laptop + external monitor, NVidia graphics, nouveau driver).