Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nemo: segfault with sidebar in treeview-mode #2265

Closed
smurphos opened this issue Dec 8, 2019 · 9 comments
Closed

nemo: segfault with sidebar in treeview-mode #2265

smurphos opened this issue Dec 8, 2019 · 9 comments
Assignees

Comments

@smurphos
Copy link
Contributor

smurphos commented Dec 8, 2019

Hi,

I've seen occasional reports of this on the Mint forums for older Nemo versions so checked to see if it's reproducible in the beta. It is albeit I can't provide precise steps to reproduce. Basically left and right click in the side pane. expanding and closing entries in treeview mode and at some point nemo will seg fault. In my initial test the crash happened within a couple of minutes.

I'd launched nemo from the terminal specifically to test this....

Terminal output

steve@steve-VirtualBox:~$ nemo
Nemo-Share-Message: 07:59:11.056: Called "net usershare info" but it failed: 'net usershare' returned error 255: mkdir failed on directory /var/run/samba/msg.lock: Permission denied
net usershare: cannot open usershare directory /var/lib/samba/usershares. Error No such file or directory
Please ask your system administrator to enable user sharing.


** (nemo:1885): CRITICAL **: 08:00:46.137: fm_tree_model_get_path: assertion 'iter_is_valid (tree_model, iter)' failed

(nemo:1885): Gtk-CRITICAL **: 08:00:46.137: gtk_tree_model_row_deleted: assertion 'path != NULL' failed
sys:1: Warning: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

** (nemo:1885): CRITICAL **: 08:00:46.138: fm_tree_model_get_path: assertion 'iter_is_valid (tree_model, iter)' failed

(nemo:1885): Gtk-CRITICAL **: 08:00:46.138: gtk_tree_model_row_deleted: assertion 'path != NULL' failed
sys:1: Warning: g_object_unref: assertion 'object->ref_count > 0' failed

** (nemo:1885): CRITICAL **: 08:01:38.867: fm_tree_model_get_value: assertion 'iter_is_valid (FM_TREE_MODEL (model), iter)' failed
sys:1: Warning: g_value_transform: assertion 'G_IS_VALUE (src_value)' failed
sys:1: Warning: unable to set property 'weight' of type 'gint' from value of type '(null)'

** (nemo:1885): CRITICAL **: 08:01:38.868: fm_tree_model_get_value: assertion 'iter_is_valid (FM_TREE_MODEL (model), iter)' failed
sys:1: Warning: unable to set property 'style' of type 'PangoStyle' from value of type '(null)'

** (nemo:1885): CRITICAL **: 08:01:38.868: fm_tree_model_get_value: assertion 'iter_is_valid (FM_TREE_MODEL (model), iter)' failed
sys:1: Warning: unable to set property 'text' of type 'gchararray' from value of type '(null)'

** (nemo:1885): CRITICAL **: 08:01:38.868: fm_tree_model_get_value: assertion 'iter_is_valid (FM_TREE_MODEL (model), iter)' failed
sys:1: Warning: ../../../../gobject/gtype.c:4265: type id '0' is invalid
sys:1: Warning: can't peek value table for type '<invalid>' which is not currently referenced
Segmentation fault (core dumped)

Stack Trace - https://termbin.com/wnni

I note the final output from the terminal is the same as reported here for this reproducible issue related to treeview in the main pane - #2256

@smurphos
Copy link
Contributor Author

smurphos commented Dec 8, 2019

Another seg-fault with different terminal output this time. In this instance I used a 2nd terminal to create and remove some files in tmp is a similar way to the linked issue whilst having the file system expanded in the sidepane in tree-view mode.

Commands run in 2nd terminal

steve@steve-VirtualBox:~$ mkdir -p /tmp/test/test2
steve@steve-VirtualBox:~$ touch /tmp/test/test2/test.text
steve@steve-VirtualBox:~$ rm /tmp/test/test2/test.text
steve@steve-VirtualBox:~$ rm -R /tmp/test/test2

Nemo terminal output

steve@steve-VirtualBox:~$ nemo --debug
(nemo:1597): Gtk-DEBUG: 08:22:50.742: Connecting to session manager
(nemo:1597): Gtk-DEBUG: 08:22:50.742: Registering client 'org.Nemo' ''
(nemo:1597): Gtk-DEBUG: 08:22:50.745: Registered client at '/org/gnome/SessionManager/Client30'
** (nemo:1597): DEBUG: 08:22:50.911: Open called on the GApplication instance; 1 files
Nemo-Share-Message: 08:22:51.369: Called "net usershare info" but it failed: 'net usershare' returned error 255: mkdir failed on directory /var/run/samba/msg.lock: Permission denied
net usershare: cannot open usershare directory /var/lib/samba/usershares. Error No such file or directory
Please ask your system administrator to enable user sharing.


** (nemo:1597): CRITICAL **: 08:23:13.788: fm_tree_model_get_path: assertion 'iter_is_valid (tree_model, iter)' failed

(nemo:1597): Gtk-CRITICAL **: 08:23:13.788: gtk_tree_model_row_deleted: assertion 'path != NULL' failed
sys:1: Warning: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
sys:1: Warning: g_object_unref: assertion 'object->ref_count > 0' failed

** (nemo:1597): CRITICAL **: 08:26:48.664: nemo_file_ref: assertion 'NEMO_IS_FILE (file)' failed
Segmentation fault (core dumped)

Stack trace - https://termbin.com/q1dl

@gm10
Copy link
Contributor

gm10 commented Dec 8, 2019

It is albeit I can't provide precise steps to reproduce.

If you want one, right clicking on any mount point (e.g. to eject a flash drive) will make it crash every time. Always has, i.e. that's not a regression.

@smurphos
Copy link
Contributor Author

smurphos commented Dec 8, 2019

That doesn't actually crash nemo for me

@gm10
Copy link
Contributor

gm10 commented Dec 8, 2019

@smurphos it should be a 100% repro. Just so we're not misunderstood, I meant right-clicking in the tree view, and I didn't mean the root "File System".

Try this:
Create a VM with two instances of the 19.3 Cinnamon iso (or previous releases) as storage devices, then boot to the live environment, open nemo, switch to tree view and right click the other CD. It will seg fault.

@smurphos
Copy link
Contributor Author

smurphos commented Dec 8, 2019

A variation of that crashes without fail - adding an ISO image to Vbox's virtual drive and right clicking on it in treeview....

steve@steve-VirtualBox:~$ nemo --debug
(nemo:1718): Gtk-DEBUG: 16:58:46.922: Connecting to session manager
(nemo:1718): Gtk-DEBUG: 16:58:46.922: Registering client 'org.Nemo' ''
(nemo:1718): Gtk-DEBUG: 16:58:46.925: Registered client at '/org/gnome/SessionManager/Client32'
** (nemo:1718): DEBUG: 16:58:47.088: Open called on the GApplication instance; 1 files
Nemo-Share-Message: 16:58:47.624: Called "net usershare info" but it failed: 'net usershare' returned error 255: mkdir failed on directory /var/run/samba/msg.lock: Permission denied
net usershare: cannot open usershare directory /var/lib/samba/usershares. Error No such file or directory
Please ask your system administrator to enable user sharing.


** (nemo:1718): CRITICAL **: 16:59:01.468: fm_tree_model_get_value: assertion 'iter_is_valid (FM_TREE_MODEL (model), iter)' failed
sys:1: Warning: ../../../../gobject/gtype.c:4265: type id '0' is invalid
sys:1: Warning: can't peek value table for type '<invalid>' which is not currently referenced
Segmentation fault (core dumped)

Stack trace - https://termbin.com/zo1j

@clefebvre
Copy link
Member

Reported against v4.4.1.

@clefebvre clefebvre changed the title Nemo 4.4.1 will seg fault at some point with sidebar in treeview-mode nemo: segfault with sidebar in treeview-mode Dec 9, 2019
mtwebster referenced this issue Dec 11, 2019
context menu for showing, it is owned by the tree model.

Fixes an issue mentioned in linuxmint/mint19.3-beta#34.
@mtwebster
Copy link
Member

I've pushed a fix for the mount issue mentioned here, but am unable to reproduce the OP's issue in the manner described in #2256. Some more specific steps to reproduce this issue would be helpful, if the fixes I just made don't affect it.

@mtwebster
Copy link
Member

I'm going to move this to cinnamon for now and leave open, until I can get steps to reliably reproduce the original issue.

@mtwebster mtwebster transferred this issue from linuxmint/mint19.3-beta Dec 12, 2019
@smurphos
Copy link
Contributor Author

Thanks Michael - I've tested with 4.4.2 and as it stands can't reproduce any of the seg-faults originally reported. Happy for this to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants