Fix issue when generating video thumbnails from network shares #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will probably fix this reported issue #2979 |
endoedgar
changed the title
mtwebster
reviewed
Jul 17, 2023
| GError *err = NULL; | ||
| char *local_filepath = g_file_get_path(file); | ||
|
|
||
| image_uri = g_filename_to_uri(local_filepath, NULL, &err); |
There was a problem hiding this comment.
You could use g_file_peek_path() here and save having to set and free local_filepath
mtwebster
reviewed
Jul 17, 2023
|
|
||
| if(err) { | ||
| DEBUG("(Thumbnail Thread) Failed to convert local_filepath to uri: %s", err->message); | ||
| g_free(err); |
This was referenced Aug 9, 2023
mtwebster
pushed a commit
that referenced
this pull request
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that Nemo wasn´t generating video thumbnails whenever I was in a network share (I was using the default ffmpegthumbnailer). I was finding it weird because image thumbnails were fine.
Digging into the code I've found that we are passing the smb:// file uri to the gnome_desktop_thumbnail_factory_generate_thumbnail cinnamon-desktop function, and that in turn is calling g_filename_to_uri whenever it finds a %i in a thumbnailer.
That was exactly the case with ffmpegthumbnailer. Image thumbnailers normally don't use the %i format, but %u instead.
Since g_filename_to_uri doesn´t support anything else than local file:// uri, I've added this code to take care of that and fix the thumbnail generation.