Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount-archive.nemo_action: Use gvfsd-archive instead of gnome-disk-image-mounter #3371

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlosmintfan
Copy link

@carlosmintfan carlosmintfan commented Feb 24, 2024

Fixes #3231
Regression introduced in b7bd80d.
#2811 stays fixed as we use /usr/libexec/gvfsd-archive instead of /usr/lib/gvfs/gvfsd-archive now.

TODO:

  • Check other distros
  • Check the C code as it's possible there's some dependency checking stuff there to make sure dependencies like this gvfs exist before showing the action

gnome-disk-image-mounter.

Fixes linuxmint#3231
Regression introduced in b7bd80d.
linuxmint#2811 stays fixed as we use /usr/libexec/gvfsd-archive instead of /usr/lib/gvfs/gvfsd-archive now.
@carlosmintfan
Copy link
Author

Don't know if replacers like %U work inside quotes in the latest version of nemo though, there has been some regression…

Copy link
Contributor

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@claudiux
Copy link
Member

Please take a look at:
#1942

@carlosmintfan
Copy link
Author

Please take a look at: #1942

Could you explain more? I'm not using /usr/lib/gvfs/gvfsd-archive or /usr/lib/gvfs-archive, I'm using /usr/libexec/gvfsd-archive.

@claudiux
Copy link
Member

claudiux commented Apr 27, 2024

You need to check whether /usr/libexec/gvfsd-archive exists on all distributions using Cinnamon.
This is the work I do every time I need to make sure my applet dependencies exist for these distribs (Arch, Fedora, OpenSuse, Manjaro...).

@carlosmintfan
Copy link
Author

carlosmintfan commented Apr 27, 2024

You need to check whether /usr/libexec/gvfsd-archive exists on all distributions using Cinnamon. This is the work I do every time I need to make sure my applet dependencies exist for these distribs (Arch, Fedora, OpenSuse, Manjaro...).

All right, have you downloaded all these and boot these (eg. in a VM) or is there some easier way? I've heard something of [EDIT: what I wrote before was a stupid page, use distrosea.com] or something like that, I'll take a look in the next days. Also, I may have to check the C code as it's possible there's some dependency checking stuff there also to make sure they exist before showing the action.

@carlosmintfan carlosmintfan marked this pull request as draft April 27, 2024 19:18
@claudiux
Copy link
Member

I always start the search with the keyword and the name of the distro. Exemple, searching gvfsd-archive arch, I found: https://bbs.archlinux.org/viewtopic.php?id=238968
Why not replace /usr/libexec/gvfsd-archive file="%U" with gio mount %U?

Then, yes, I test my code on VMs to make sure it works properly.

@carlosmintfan
Copy link
Author

carlosmintfan commented Apr 27, 2024

I always start the search with the keyword and the name of the distro. Exemple, searching gvfsd-archive arch, I found: https://bbs.archlinux.org/viewtopic.php?id=238968 Why not replace /usr/libexec/gvfsd-archive file="%U" with gio mount %U?

Then, yes, I test my code on VMs to make sure it works properly.

#3231 (comment) (see ubuntuforums link)
You have to urlencode the filename somehow?? (Or does nemo do this automatically??)

@claudiux
Copy link
Member

claudiux commented Apr 27, 2024

Bad news. I've tried to mount my linuxmint-21.3-cinnamon-64bit.iso file and:

  • gnome-disk-image-mounter linuxmint-21.3-cinnamon-64bit.iso works well.
  • /usr/libexec/gvfsd-archive file="/complete/path/to/linuxmint-21.3-cinnamon-64bit.iso" doesn't work.
  • gio mount linuxmint-21.3-cinnamon-64bit.iso doesn't work.

Tested on LM 21.3 Cinnamon 6.0.4.

@carlosmintfan
Copy link
Author

Bad news. I've tried to mount my linuxmint-21.3-cinnamon-64bit.iso file and:

* `gnome-disk-image-mounter linuxmint-21.3-cinnamon-64bit.iso` works well.

* `/usr/libexec/gvfsd-archive file="/complete/path/to/linuxmint-21.3-cinnamon-64bit.iso"` doesn't work.

* `gio mount linuxmint-21.3-cinnamon-64bit.iso` doesn't work.

Tested on LM 21.3 Cinnamon 6.0.4.

Okay, I'll mount my pearOS_Catalina_64bit-beta-2021.07.13.iso file.

  • gnome-disk-image-mounter pearOS_Catalina_64bit-beta-2021.07.13.iso works well.
  • /usr/libexec/gvfsd-archive file="/home/karl/Downloads/ISOs/pearOS_Monterey_64bit-12-beta-2021.07.01.iso" works, but in contrast to gnome-disk-image-mounter no dialog about having been mounted appears, you just have to click it in the filemanager.
  • gio mount doesn't work (you have to urlencode the filename and I haven't done it)

@claudiux
Copy link
Member

OK, url-encoding the path, that works: /usr/libexec/gvfsd-archive file="/home/claude/T%C3%A9l%C3%A9chargements/LinuxMint/linuxmint-21.3-cinnamon-64bit.iso" but once unmounted, I can't re-mount it with the same command.

gio mount /home/claude/T%C3%A9l%C3%A9chargements/LinuxMint/linuxmint-21.3-cinnamon-64bit.iso doesn't work at all.

@claudiux
Copy link
Member

gnome-disk-image-mounter works well every time.

@claudiux
Copy link
Member

you just have to click it in the filemanager.

Or open it using the removable-drives applet.

@claudiux
Copy link
Member

To open zip files, use file-roller %U.

@carlosmintfan
Copy link
Author

To open zip files, use file-roller %U.

Yes, but we want to mount them, not just open them…for gio mount, well, you have to urlencode even the slashes, I think.

@carlosmintfan
Copy link
Author

once unmounted, I can't re-mount it with the same command

That's bad…

@carlosmintfan
Copy link
Author

carlosmintfan commented May 17, 2024

Oh no, /usr/libexec doesn't even exist on Arch Linux, but it seems gvfs too doesn't even exist there, have to try a different version than the one at distrosea...
Manjaro Cinnamon, full edition, oh no, doesn't exist.
Fedora 40 Cinnamon, exists, yeah!
Opensuse..no Cinnamon edition, taking gnome. /usr/libexec exists, but no gvfsd-archive
Spiral Linux...exists!

@claudiux
Copy link
Member

On Arch: $ pacman -Ss gvfs

extra/gvfs 1.54.0-2 (gnome) [installé]
    Virtual filesystem implementation for GIO
extra/gvfs-afc 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (AFC backend; Apple mobile
    devices)
extra/gvfs-goa 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (Gnome Online Accounts backend;
    cloud storage)
extra/gvfs-google 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (Google Drive backend)
extra/gvfs-gphoto2 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (gphoto2 backend; PTP camera, MTP
    media player)
extra/gvfs-mtp 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (MTP backend; Android, media
    player)
extra/gvfs-nfs 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (NFS backend)
extra/gvfs-onedrive 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (Microsoft OneDrive backend)
extra/gvfs-smb 1.54.0-2 (gnome)
    Virtual filesystem implementation for GIO (SMB/CIFS backend; Windows client)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't mount a zip-archive
3 participants