bugfix: ugly white border (gtk 3.20>)

[ghost]

No description provided.

[leigh123linux]

You need to add conditionals so that gtk-3.20< isn't affected by this change

[JosephMcc]

You need to add conditionals so that gtk-3.20< isn't affected by this change

Yes you do. As you can tell I've messed with that before. I'd rather it not affect gtk < 3.20.

@leigh123linux in Fedora you might want to tweak your theme a bit once this is merged. I did this in Mint-Y: linuxmint/mint-y-theme@735fd68#diff-68426d2ebfa0f55850ee1027cde252bfR841

It brings back the border between the bottom bars and the notebook.

[ghost]

ok I have added a gtk version check before I hide the border. ;)

[JosephMcc]

Sorry to keep nitpicking you on such a small thing but I'd prefer if you follow our typical conventions for this.

    gtk_notebook_set_scrollable (GTK_NOTEBOOK (notebook), TRUE);

#if GTK_CHECK_VERSION (3, 20, 0)
    gtk_notebook_set_show_border (GTK_NOTEBOOK (notebook), FALSE);
#endif

    gtk_notebook_set_show_tabs (GTK_NOTEBOOK (notebook), FALSE);

This makes them easier to find and clean up later on.

When formatting your code using if() statements and such please follow conventions used throughout the rest of the code. So something like

if (some_condition)
{
    // some stuff
}

I'd appreciate if you you update the PR and squash it down to a single commit. Not sure we need three commits to change a single line :)

[JosephMcc]

Thanks.

[ghost]

Done! 🍔 :)

[itzexor]

I tested this and it fixes the issue on gtk 3.22.15. Checked with a few gtk themes and xed themes and didn't see any issues. 👍

[leigh123linux]

@JosephMcc Thanks for the pointer, does this commit look ok?

horst3180/arc-theme#790

[JosephMcc]

@leigh123linux I don't think you can use the XedFileBrowserWidget class name. I haven't worked much yet with theming beyond 3.18 but I don't think the use of class names is supported any longer. You would have to test on your end but I think .xed-window .small-button would work in this case. So yo could add the .small-button part within your .xed-window block in the sass file.

[leigh123linux]

@JosephMcc Thanks, does that look better?

I don't see any additional warnings with either.

[JosephMcc]

As far as I understand it, that should work. You should be able to tell. It makes the navigation buttons in the sidebar file browser widget a good bit smaller. They were quite large originally in Mint-Y without that.