Improved function validmac in helperfunctions.

linuxmuster · Jul 14, 2023 · 3e3e4ad · 3e3e4ad
1 parent bf571a5
commit 3e3e4ad
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/serverfs/usr/share/linuxmuster/linbo/helperfunctions.sh b/serverfs/usr/share/linuxmuster/linbo/helperfunctions.sh
@@ -2,7 +2,7 @@
 # helperfunctions for linbo scripts
 #
 # thomas@linuxmuster.net
-# 20220803
+# 20230714
 #
 
 # get linuxmuster environment variables
@@ -51,8 +51,7 @@ validip(){
 
 # test valid mac address syntax
 validmac(){
-  [ `expr length $1` -ne "17" ] && return 1
-  (expr match "$1" '\([a-fA-F0-9-][a-fA-F0-9-]\+\(\:[a-fA-F0-9-][a-fA-F0-9-]\+\)\+$\)') &> /dev/null || return 1
+  [[ "$1" =~ ^([a-fA-F0-9]{2}:){5}[a-fA-F0-9]{2}$ ]] || return 1
 }
 
 # test for valid hostname