Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose mariadb database path #144

Closed
wants to merge 1 commit into from

Conversation

JasperE84
Copy link

@JasperE84 JasperE84 commented Nov 4, 2022

Current docker-compose example will result in data loss on container recreation

Description:

Changed docker-compose to achieve data persistence on container recreation

Benefits of this PR and context:

Prevents accidental data loss

How Has This Been Tested?

Checked for bookstack content persistence after running:

docker-compose stop
docker-compose rm -f
docker-compose pull
docker-compose up -d --build --remove-orphans
docker image prune

Current docker-compose example will result in data loss on container recreation
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@JasperE84 JasperE84 marked this pull request as ready for review November 4, 2022 12:36
@thespad
Copy link
Member

thespad commented Nov 4, 2022

Our example compose uses our Mariadb container which uses /config for persistent data, you appear to have confused it for the official mariadb image.

@thespad thespad closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants