Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In this PR I'm trying to add IPv6 support to the image.
The biggest challenge I had was:
ipv6=
and expect duckdns to fetch it automaticallyip=&ipv6=[actual_ipv6]
ends up only setting the IPv6 leaving the IPv4 untouched.I'm unsure whether this is the right approach, but I couldn't find a way of making fewer HTTP requests.
I'm very open to suggestions. I'm not really good at bash.
@sparklyballs @aptalca