Append logs to file and rotate logs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I have chosen the parameters in |
|
I am a bot, here are the test results for this PR: |
aptalca
approved these changes
Mar 9, 2022
Issue & PR Tracker
automation
moved this from PRs & in progress issues
to Team approved, ready for merge
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As discussed in #31, this now logs the output of
/app/duck.shby appending to/config/duck.loginstead of overwriting it. A cronjob forlogrotateis used to avoid excessive file sizes of the log file.Benefits of this PR and context:
When using
LOG_FILE=true, the expectation is that it logs the history to a file instead of the current status.How Has This Been Tested?
I have tested logrotate in a local
docker-duckdnsimage on macOS (M1) with a simulated largeduck.logfile.Source / References: