Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scarf link to generic URL #257

Merged
merged 1 commit into from May 12, 2024
Merged

Change scarf link to generic URL #257

merged 1 commit into from May 12, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented May 9, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

We can't link users to a publicly visible page for a given image so it makes more sense just to have a generic link to Scarf to make users aware of what it is. At least until/if they provide the option of public stats publishing.

In any case, the URL is wrong as they've changed the site layout, so it's now in the form

https://app.scarf.sh/packages/linuxserver-ci/docker/linuxserver%2Fplex

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team May 9, 2024 18:11
@thespad thespad self-assigned this May 9, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/73a542bd-pkg-73a542bd-dev-270cd76b8849facfbc051b5a99e21baf21ab7de7-pr-257/index.html
https://ci-tests.linuxserver.io/lspipepr/jenkins-builder/73a542bd-pkg-73a542bd-dev-270cd76b8849facfbc051b5a99e21baf21ab7de7-pr-257/shellcheck-result.xml

Tag Passed
amd64-73a542bd-pkg-73a542bd-dev-270cd76b8849facfbc051b5a99e21baf21ab7de7-pr-257
arm64v8-73a542bd-pkg-73a542bd-dev-270cd76b8849facfbc051b5a99e21baf21ab7de7-pr-257

@thespad thespad merged commit 95d878d into monthly May 12, 2024
6 checks passed
@thespad thespad mentioned this pull request May 12, 2024
4 tasks
@thespad thespad deleted the monthly-scarf-link branch May 21, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants