expand ability to add new trusted domains via env var #226
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR: |
| else | ||
| for domain in $TRUSTED_DOMAINS | ||
| do | ||
| occ config:system:set trusted_domains $i --value=$domain |
There was a problem hiding this comment.
<error line="12" column="58" severity="info" message="Double quote to prevent globbing and word splitting." source="ShellCheck.SC2086"/>
occ config:system:set trusted_domains "$i" --value="$domain"
<error line="12" column="58" severity="info" message="Double quote to prevent globbing and word splitting." source="ShellCheck.SC2086"/>
|
I am a bot, here are the test results for this PR: |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I am a bot, here are the test results for this PR: |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
|
Description:
Adding another container init step to do this on startup.
Benefits of this PR and context:
I'am using this docker image on Unraid behind a Traefik Proxy. Proxing Nextcloud will be something which is done by many users I would guess and I thought a clean solution with a optional and additional environment variable to add trusted domains would be nice for everybody. Otherwise you would have to somehow find a IMO dirty way to interact with a config file which is not exposed by default. This could also be in an ephemeral way which also annoying.
How Has This Been Tested?
I've tested this small script within a linux container and the occ command within the linuxserver container
Source / References: