Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to allow ssmtp to work out of the box #40

Merged
merged 4 commits into from
Jun 6, 2019

Conversation

aboutte
Copy link
Contributor

@aboutte aboutte commented May 15, 2018

  • rename to conf file so it is a little more clear
  • link the ssmtp.conf into /etc/ssmtp/
  • update sendmail command in pathnames so it utilizes ssmtp

Without these changes I was not able to the docker container to send email notifications.

@LinuxServer-CI
Copy link
Collaborator

Can an admin please whisper to jenkins to test this PR.

@tobbenb
Copy link
Member

tobbenb commented May 15, 2018

You have to find another way to get the ssmtp in the /etc folder. Symlinking to a volume mount is not something we want. Symlinks inside the container is ok.

@aboutte
Copy link
Contributor Author

aboutte commented May 15, 2018

@tobbenb is this better?

@tobbenb
Copy link
Member

tobbenb commented Jul 27, 2018

Jenkins test this please

@tobbenb
Copy link
Member

tobbenb commented Jul 27, 2018

Sorry. I didn't remember that I commented here.

Copy link
Member

@tobbenb tobbenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to a copy only if exist?
Same format as the symlink part in the 30-config.

@aboutte
Copy link
Contributor Author

aboutte commented Aug 3, 2018

@tobbenb done

@homerr homerr added this to Needs review in Issue & PR Tracker Feb 27, 2019
@homerr homerr self-assigned this Feb 27, 2019
@aptalca aptalca moved this from Ready for approval to Needs team review in Issue & PR Tracker Feb 28, 2019
@ironicbadger
Copy link
Contributor

LGTM

@ironicbadger ironicbadger merged commit 283ca73 into linuxserver:master Jun 6, 2019
Issue & PR Tracker automation moved this from Needs team attention to Done Jun 6, 2019
@aboutte aboutte deleted the ssmtp branch June 7, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants