Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Authentik configs, update Authelia configs #331

Merged
merged 27 commits into from
Feb 10, 2023
Merged

Add Authentik configs, update Authelia configs #331

merged 27 commits into from
Feb 10, 2023

Conversation

drizuid
Copy link
Member

@drizuid drizuid commented Feb 1, 2023 •
edited by nemchik

confs for tik, tested internally and externally. requires tik to be configured properly. Only tested with provider forward auth (single app) and application per.

@nemchik edit:
This PR has been repurposed to include reworking of the authentik configs and updates to the authelia configs. All changes have been discussed with the respective devs and tested by me and additional users.

MERGE THIS FIRST linuxserver/reverse-proxy-confs#521

@drizuid drizuid changed the title Add files via upload Add includable authentik confs Feb 1, 2023
@drizuid drizuid mentioned this pull request Feb 1, 2023
Closed
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/shellcheck-result.xml

2 similar comments
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/shellcheck-result.xml

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/shellcheck-result.xml

@nemchik nemchik marked this pull request as draft February 1, 2023 22:52
@nemchik
Copy link
Member

nemchik commented Feb 1, 2023

Converted to draft. Needs a few things. I'll add proper review tomorrow.

nemchik
nemchik requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review. Some of the syntax for authelia (which you stated this was originally based on) may be changing in #330 and you may consider bringing some of those changes here as well.

root/defaults/nginx/authentik-location.conf Outdated Show resolved Hide resolved
root/defaults/nginx/authentik-server.conf Outdated Show resolved Hide resolved
@drizuid
Copy link
Member Author

drizuid commented Feb 2, 2023

Initial review. Some of the syntax for authelia (which you stated this was originally based on) may be changing in #330 and you may consider bringing some of those changes here as well.

The config is not based on authelia at all, only on the file structure. The configs are directly from the nginx section of authentik's guide.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/shellcheck-result.xml

1 similar comment
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-f649bd6c-pr-331/shellcheck-result.xml

@nemchik nemchik mentioned this pull request Feb 5, 2023
Merged
@nemchik
Copy link
Member

nemchik commented Feb 5, 2023

Should be merged AFTER linuxserver/reverse-proxy-confs#521 so that the next swag build includes the updates proxy confs

@nemchik
Remove authelia site-conf
9e7ef61 
A proxy-conf is already included
@nemchik nemchik mentioned this pull request Feb 8, 2023
Merged
@drizuid drizuid mentioned this pull request Feb 9, 2023
Closed
@rcdailey
Copy link

rcdailey commented Feb 9, 2023

This is fantastic. Thank you.

@nemchik nemchik changed the title Add includable authentik confs Add Authentik configs, update Authelia configs Feb 10, 2023
@nemchik nemchik marked this pull request as ready for review February 10, 2023 00:37
@nemchik nemchik requested a review from a team February 10, 2023 00:38
nemchik
nemchik approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but also requesting additional approval since I was heavily involved in changes merged into this branch.

@nemchik nemchik requested a review from a team February 10, 2023 00:50
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-4ca06d75-pr-331/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.2.0-pkg-4ca06d75-pr-331/shellcheck-result.xml

@nemchik nemchik merged commit 83bc8a3 into master Feb 10, 2023
@nemchik nemchik deleted the driz-tik branch February 10, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drizuid @LinuxServer-CI @nemchik @rcdailey