Add ipv6 support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but has it been tested extensively? I have no ipv6 experience or testing capability |
|
I can confirm in my environment where I have no ipv6 at all that this does not interfere with ipv4. We also had a user on discord noted in the referenced issue from the other repo confirm that in their environment which is ipv6 only and no ipv4 that this worked for them. I did a good amount of reading to confirm this seems to be the most common way of doing ipv6 and ipv4 together. (there's other more hack-ish ways but i didn't trust them). |
|
Alright, if it doesn't break anything, I'm ok with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from linuxserver/docker-letsencrypt#180