Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 6100WL class from Bamboo #261

Closed
wants to merge 2 commits into from

Conversation

martinhath
Copy link

The buttons does not send 0x110-0x114, as already commented in the file:

Buttons are no loger RIGHT, LEFT, FORWARD, and BACKWARD.
The buttons are now reported as numbered buttons as with
the Intuos Pro series.

This can be checked with libinput record, which, on my system, outputs

  events:
  - evdev:
    - [  0,      0,   1, 256,       1] # EV_KEY / BTN_0                     1
  - evdev:
    - [  0,      0,   3,  40,      15] # EV_ABS / ABS_MISC                 15 (+15)
    - [  0,      0,   0,   0,       0] # ------------ SYN_REPORT (0) ---------- +0ms
  - evdev:
    - [  0, 135988,   1, 256,       0] # EV_KEY / BTN_0                     0
    - [  0, 135988,   3,  40,       0] # EV_ABS / ABS_MISC                  0 (-15)
    - [  0, 135988,   0,   0,       0] # ------------ SYN_REPORT (0) ---------- +135ms

where BTN_0 == 0x100 is the evdev code sent.

When the class is Bamboo the heuristic here set the button code to BTN_LEFT == 0x110.

Applying this commit made libinput debug-events output events when the buttons are clicked, vs. before when nothing happened.

I'm not sure if Intuos3 is really the right class to use here, but it seems to work well.

The buttons does not send `0x110-0x114`, as already commented in the file:

> Buttons are no loger RIGHT, LEFT, FORWARD, and BACKWARD.
> The buttons are now reported as numbered buttons as with
> the Intuos Pro series.
@@ -21,7 +21,7 @@
Name=Wacom Intuos BT M
ModelName=CTL-6100WL
DeviceMatch=usb:056a:0378;bluetooth:056a:0379
Class=Bamboo
Class=Intuos3
Copy link
Member

@whot whot Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use the EvdevCodes here. The Class tag is too ambiguous, not used outside of libwacom and mapping this to a 'random' other class just to hope for the right behaviour is bound to break at some point. EvdevCodes is the proper solution for tablets that send events on different codes than expected.

edit: I filed #262 now to deprecate the Class usage

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this definitely makes sense. I removed the Class and put in the evdev codes in d66563b.

Copy link
Member

@whot whot Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I was imprecise here: we still need the Class= line, it'll just end up being unused.

edit: IOW, keep the original Class=Bamboo with the extra line for the codes and we should be good.

@whot
Copy link
Member

whot commented Jun 23, 2020

Superseded by #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants