Add Panasonic FZ-G2 #307
Open
Add Panasonic FZ-G2 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sysinfo script used to perform two independent passes through sysfs looking for data. Data for devices was logged from both passes, but only devices found in the latter pass would have e.g. their HID descriptors copied. Ideally we should handle all devices (regardless of where they're found in sysfs) the same. To allow this, we generate and iterate over a combined list of devices. This combined list can theoretically recognize slightly more devices since the second loop uses the same list of IDs as the first loop (which contains both ACPI and USB IDs).
Declare a list of IDs and modules that we care about upfront and then make use of these lists (or modified equivalents) wherever we can. Helps to make sure we don't miss any cases when adding new IDs.
Moves the initialization of the exit trap and directory creation to the very beginning of the script.
Use a combination of exec and set to save all the (uncaught) stderr output to a file and have bash print out each command as its executed. This gives us information about exactly what data was expected to be gathered and what steps (if any) failed.
Instead of hardcoding the search string for our dmesg log extraction, we reuse the REGEX_VENDORS and REGEX_MODULES variables set up top that define the hardware and software we're interested in.
The xorg.conf[.d] configurations and udev rules can make a significant difference to a tablet working as expected or not. Go ahead and add these to the set of data we gather from systems for analysis.
Newer versions of libinput have moved away from providing a number of separate utility commands to having everyting available through just the 'libinput' command. This breaks the sysinfo script's call out to libinput-list-devices. This commit now first checks if the command exists and runs either it or the new alternative. Ref: #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: #306