Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Library -> (artist)id's missing #2

Open
tadly opened this issue Nov 18, 2015 · 1 comment
Open

My Library -> (artist)id's missing #2

tadly opened this issue Nov 18, 2015 · 1 comment
Labels

Comments

@tadly
Copy link
Member

tadly commented Nov 18, 2015

In case a user uploaded songs to Play Music it might be that google can't match existing
artists and therefore we end up without artistId
This will probably hold true for albumId's as well.

We also have to consider that uploaded media is poorly named (and without proper id3-tags) meaning we might end up without artist-/album name's

@tadly tadly added the bug label Nov 18, 2015
tadly pushed a commit that referenced this issue Nov 18, 2015
@tadly
Copy link
Member Author

tadly commented Nov 18, 2015

A proper implementation still needs to be made.
0f23371 just ignores missing id's for now so the addon stops crashing.

How to solve this issue properly I'm still not sure about as everything I can think of right now
feeels more like a hack :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant