_latlon: Fix conversion from DMS to decimal degrees #3
Conversation
|
I'd love to see this fix merged. Best Regards |
|
Hi @VOMAY Sorry I missed this - got lost in the noise :-( I definitely want to add the bug fix in the request in the use of string replace - thanks very much for identifying it. I'm not sure about the wrapping at 180 though - I'm not sure that this is a function of reading the SINEX file. More a decision about what to do once it is read. Particularly coming from NZ, near 180, I'd need to check the impact of this on downstream software. So at the moment my preference would be to not include this without further reading. |
|
Dear @ccrook I understand your concern with the 180 in NZ, although I think keeping the range between -180 and 180 is the result expected by most users. I cannot recall reading longitude > 180 is a SINEX file. |
|
@VOMAY I have added your fix for negative angles (hence the merge conflict) - thanks again for that. I'm still not inclined to modify the range of longitudes. My reason is that if that is what is in the SINEX file then that is what I want to see. If your SINEX files don't have longitudes greater than 180 then I guess this code wouldn't be used in any case. I'm sorry this isn't what you want but that is my preference at the moment. |
No description provided.