Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Nix #174

Closed
wants to merge 3 commits into from
Closed

feat: Support Nix #174

wants to merge 3 commits into from

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Aug 21, 2021

To test on for example Ubuntu:

  1. Install Nix
  2. cd into the project directory
  3. Run nix-shell

This enters a new nested shell with pre-commit and all the Python packages installed.

@l0b0 l0b0 force-pushed the feat/support-nix branch 2 times, most recently from 5dd0183 to 34c2741 Compare August 23, 2021 21:51
@l0b0 l0b0 marked this pull request as draft August 23, 2021 21:51
@l0b0 l0b0 force-pushed the feat/support-nix branch 2 times, most recently from 8be4984 to 22a55df Compare August 25, 2021 23:25
@l0b0 l0b0 marked this pull request as ready for review September 2, 2021 04:02
@l0b0 l0b0 marked this pull request as draft September 2, 2021 04:03
@l0b0 l0b0 marked this pull request as ready for review September 21, 2021 20:44
@l0b0 l0b0 marked this pull request as draft September 21, 2021 20:44
@l0b0 l0b0 marked this pull request as ready for review September 21, 2021 20:57
@imincik
Copy link

imincik commented Sep 21, 2021

@l0b0 , I am still not sure if poetry2nix in particular is ready to be adopted by all of us. There is quite steep learning curve for Nix in general and I think poetry2nix needs more time to mature.

@l0b0
Copy link
Contributor Author

l0b0 commented Sep 21, 2021

@l0b0 , I am still not sure if poetry2nix in particular is ready to be adopted by all of us. There is quite steep learning curve for Nix in general and I think poetry2nix needs more time to mature.

Can you point to any specific issues with poetry2nix? It builds, and the resulting Nix shell works. I don't think repeating all the packages in a Nix expression is better than poetry2nix.

Edit: Actually, there is still one issue when running coverage. Let's just freeze this change for now - I can always get back to it later.

@l0b0 l0b0 closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants