-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow TODO in comments #9
Conversation
fc15cab
to
b656cb0
Compare
@dwsilk 80 character limit on git commit body messages! that is tiny, is this something we could configure? |
Looking at https://www.conventionalcommits.org/en/v1.0.0/
which implies this 80 character limit is not really part of the spec |
It isn't a character limit, it's a line length limit - it wants you to wrap text at character 80. It's not part of conventional commits, it's part of the standard rules in We could configure it to be longer by default in
This is the link @palmerj provided on the original pull request on commit linting, it recommends wrapping text at 72 chars: https://chris.beams.io/posts/git-commit/#wrap-72 On this particular issue, I feel like there are two different groups of users and no ideal middle ground that suits both. |
I think it would be good to have summary comment at 50 characters. Also having the body context wrapped (i.e newline) at 72 characters is the nicest for me when viewing |
Created an issue regarding this here: #12 The discussion will be lost on this unrelated PR. |
@blacha could you change your commit body to:
to get this through before we resolve the commit message body length configuration. |
b656cb0
to
5ce3d94
Compare
TODO is useful to explain areas of concern to future developers.
5ce3d94
to
a5be4a8
Compare
This allows TODO: to be present in comments, it is useful to explain to future developers areas of concern inside of a codebase.