Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search to list filters #316

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add search to list filters #316

wants to merge 6 commits into from

Conversation

allanchau
Copy link
Contributor

@allanchau allanchau commented Jul 16, 2021

This PR enables searching and select all via data attributes in the list filter.

Setup

  • Pull this PR into a project.

Testing

  • Add the following attributes to a list filter
linz.formtools.filters.list(
    async (callback) => {},
    true,
    {
        data: {
            'enable-filtering': true,
            'enable-case-insensitive-filtering': true,
            'enable-full-value-filtering': true,
            'include-select-all-option': true,
        },
    }
);
  • Test the filter works as expected.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #316 (efa2eba) into master (4061afc) will not change coverage.
The diff coverage is n/a.

❗ Current head efa2eba differs from pull request most recent head ca88d11. Consider uploading reports for the commit ca88d11 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files         169      169           
  Lines        4449     4449           
  Branches     1023     1023           
=======================================
  Hits         2294     2294           
  Misses       1673     1673           
  Partials      482      482           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4061afc...ca88d11. Read the comment docs.

@allanchau allanchau requested a review from a team July 19, 2021 05:12
@allanchau allanchau self-assigned this Jul 19, 2021
@allanchau allanchau marked this pull request as ready for review July 19, 2021 05:12
Copy link
Contributor

@smebberson smebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allanchau, could you please create a page in the documentation (like this one) for widgets. Could you please document generally how to use a widget and then create a specific entry for the list widget.

For the list widget, please use the property description format (from here) and document how to use the list widget, both with and without searching?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants