Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxed ignored parameters in getTrip #7

Merged
merged 3 commits into from
Nov 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ List<LngLat> waypoints = [
final manager = OSRMManager();
final road = await manager.getRoad(
waypoints: waypoints,
geometrie: Geometries.polyline,
geometries: Geometries.polyline,
steps: true,
languageCode: "en",
);
Expand All @@ -48,10 +48,10 @@ List<LngLat> waypoints = [
final manager = OSRMManager();
final road = await manager.getTrip(
waypoints: waypoints,
roudTrip:true,
destination: DestinationGeoPointOption.last,
roundTrip:false,
source: SourceGeoPointOption.first,
geometrie: Geometries.polyline,
destination: DestinationGeoPointOption.last,
geometries: Geometries.polyline,
steps: true,
languageCode: "en",
);
Expand Down
21 changes: 13 additions & 8 deletions lib/src/osrm_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ class OSRMManager {
bool alternative = false,
bool steps = true,
Overview overview = Overview.full,
Geometries geometrie = Geometries.geojson,
Geometries geometries = Geometries.geojson,
String languageCode = "en",
}) async {
String path = generatePath(
waypoints.toWaypoints(),
steps: steps,
overview: overview,
geometry: geometrie,
geometries: geometries,
);
path += "&alternatives=$alternative";

Expand All @@ -74,7 +74,8 @@ class OSRMManager {
/// [getTrip]
/// this method used to get route from trip service api
/// used if you have more that 10 waypoint to generate route will more accurate
/// that [getRoad].
/// that [getRoad]. Please note that if one sets [roundTrip] to false, then
/// [source] and [destination] must be provided.
Future<Road> getTrip({
required List<LngLat> waypoints,
RoadType roadType = RoadType.car,
Expand All @@ -83,7 +84,7 @@ class OSRMManager {
DestinationGeoPointOption destination = DestinationGeoPointOption.any,
bool steps = true,
Overview overview = Overview.full,
Geometries geometry = Geometries.polyline,
Geometries geometries = Geometries.polyline,
String languageCode = "en",
}) async {
if (!roundTrip &&
Expand All @@ -99,7 +100,7 @@ class OSRMManager {
destination: destination,
steps: steps,
overview: overview,
geometrie: geometry,
geometries: geometries,
);
final response = await dio.get(urlReq);
if (response.statusCode == 200) {
Expand Down Expand Up @@ -153,14 +154,14 @@ extension OSRMPrivateFunct on OSRMManager {
RoadType roadType = RoadType.car,
bool steps = true,
Overview overview = Overview.full,
Geometries geometry= Geometries.polyline,
Geometries geometries = Geometries.polyline,
}) {
String url =
"$server/routed-${roadType.value}/${profile.name}/v1/diving/$waypoints";
var option = "";
option += "steps=$steps&";
option += "overview=${overview.value}&";
option += "geometries=${geometry.value}";
option += "geometries=${geometries.value}";
return "$url?$option";
}

Expand All @@ -173,11 +174,15 @@ extension OSRMPrivateFunct on OSRMManager {
DestinationGeoPointOption destination = DestinationGeoPointOption.any,
bool steps = true,
Overview overview = Overview.full,
Geometries geometrie = Geometries.polyline,
Geometries geometries = Geometries.polyline,
}) {
String baseGeneratedUrl = generatePath(
waypoints,
roadType: roadType,
steps: steps,
overview: overview,
profile: Profile.trip,
geometries: geometries,
);

return "$baseGeneratedUrl&source=${source.name}&destination=${destination.name}&roundtrip=$roundTrip";
Expand Down