Skip to content

Commit

Permalink
Disable help summary in argument completions
Browse files Browse the repository at this point in the history
  • Loading branch information
lionel- committed Dec 17, 2020
1 parent 33b5d68 commit 07782da
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions doc/newfeat.texi
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
Changes and New Features in 19.04 (unreleased):
@itemize @bullet

@item ESS[R]: Fixed performance issue with argument completions.
The help summary for the argument is no longer displayed in the
echo area. This fixes delays and hangs (#1062).

@item ESS[R]: @code{ess-command} is now more robust and resilient to hangs
and custom prompts (#1043).

Expand Down
4 changes: 3 additions & 1 deletion lisp/ess-r-completion.el
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,9 @@ To be used instead of ESS' completion engine for R versions >= 2.7.0."
(args (mapcar (lambda (a) (concat a ess-R-argument-suffix))
args)))
(all-completions arg args)))
(meta (unless (bound-and-true-p ess-r--no-company-meta)
;; Displaying help for the argument in the echo area is disabled
;; by default for performance reasons. It causes delays or hangs (#1062).
(meta (when (bound-and-true-p ess-r--company-meta)
(let ((proc (ess-get-next-available-process)))
(when (and proc
(with-current-buffer (process-buffer proc)
Expand Down

0 comments on commit 07782da

Please sign in to comment.