Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml support #9

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Yaml support #9

wants to merge 5 commits into from

Conversation

jdevera
Copy link

@jdevera jdevera commented Jul 24, 2015

I have added YAML parsing support and in the process done a bit of refactoring so that:

  • I didn't have to further indent blocks in more nested try/except
  • Tab completion for the Objectifier objects did not show internal methods, only the data

YAML parsing is conditional to the availability of a module called yaml

By prepending an underscore to the name.
Not needed for lifetime of an Objectifier, it's an internal detail.
In preparation to include more parsers without nesting blocks further.
If a yaml module is available, then yaml is an accepted input.
@dlo
Copy link
Member

dlo commented Jul 25, 2015

Looks great @jdevera, appreciate the contribution! If you could add some tests I think this will be good to go. Thanks!

@jdevera
Copy link
Author

jdevera commented Jul 25, 2015

Cool, will take a look at that next week.

@dlo
Copy link
Member

dlo commented Jul 25, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants