Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"compression" parameter is passed to smart_open.open() with incorrect version check #89

Closed
pd-nisse opened this issue Sep 1, 2021 · 2 comments
Closed

"compression" parameter is passed to smart_open.open() with incorrect version check #89

pd-nisse opened this issue Sep 1, 2021 · 2 comments

Comments

@pd-nisse
Copy link

pd-nisse commented Sep 1, 2021

S3Path passes two different sets of kwargs to smart_open.open(), depending if version >=5.0.0 or lower. This throws an error when having smart_open=5.0.0 installed, because the parameter compression got only introduced in smart_open=5.1.0.

TypeError: open() got an unexpected keyword argument 'compression'

https://github.com/RaRe-Technologies/smart_open/releases/tag/v5.1.0

Installing manually smart_open>=5.1.0 fixes this.
pd-nisse added a commit to parallel-domain/pd-sdk that referenced this issue Sep 1, 2021
@pd-nisse
Require smart_open>=5.1.0 to work around issue in S3Path: liormizr/s3…
621d8b3 
…path#89
@liormizr
Copy link
Owner

Hi @pd-nisse ,

Thanks for the issue, I'll add a fix for the next version

PR: #91

@liormizr
Copy link
Owner

Deployed in version 0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liormizr @pd-nisse