Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for symbolic links #37

Closed
wants to merge 7 commits into from
Closed

Add support for symbolic links #37

wants to merge 7 commits into from

Commits on Jun 17, 2020

  1. Add support for symbolic links 

    - Add support for symbolic links in S3
- Check for symlinks during `read` and directory traversal
- Add `S3Path.is_symlink`, `S3Path.symlink_to`, `_S3Accessor.symlink`,
  and `_S3Accessor.is_symlink`
- Refactor `ObjectSummary` instantiation to a separate method to allow
  for a new `follow_symlinks` argument to be passed, which, if True,
  results in the final non-symlink `ObjectSummary` instance being
  returned
- Fixes liormizr#35

Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    fbcfeaa View commit details
    Browse the repository at this point in the history

  2. remove f string 

    Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8f8398e View commit details
    Browse the repository at this point in the history

  3. fix syntax error 

    Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    5128e13 View commit details
    Browse the repository at this point in the history

  4. Fix redirect location assignment 

    Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    561d728 View commit details
    Browse the repository at this point in the history

  5. Don't bother checking whether existing directories are symlinks 

    Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    3aab2fb View commit details
    Browse the repository at this point in the history

  6. Update interface docs 

    Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    6ef0112 View commit details
    Browse the repository at this point in the history

  7. Fix symlink resolution 

    Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
    @techalchemy
    techalchemy committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f66ad6c View commit details
    Browse the repository at this point in the history