Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all files before commit #13

Merged
merged 7 commits into from
Apr 13, 2024
Merged

Format all files before commit #13

merged 7 commits into from
Apr 13, 2024

Conversation

luisalves00
Copy link

@luisalves00 luisalves00 commented Apr 12, 2024

Add support to apply spotless before commit.
resolves #12

Note: this removes the usage of com.github.lipiridi.spotless.applier.ToolEnvExternalSystemUtil where the behaviour created by

final String title = moduleName + " " + taskSettings.getTaskNames();

is lost.

@lipiridi
Copy link
Owner

Hello! I appreciate your contribution. I've read through your issue and understand your needs.
ToolEnvExternalSystemUtil was created in order to support maven tasks properly due to some issues encountered with the default ExternalSystemUtil
I'll test the maven part and get back to you with ideas or comments.

@lipiridi
Copy link
Owner

I added commits to the PR in order to keep supporting maven and apply spotless by commit check to the entire project.
I also came upon that the modal sync gradle execution bug is somehow fixed Youtrack issue. Just it was the blocker before to add such ability.

@lipiridi lipiridi added the enhancement New feature or request label Apr 13, 2024
@lipiridi lipiridi self-requested a review April 13, 2024 18:32
@lipiridi lipiridi merged commit a5cebdc into lipiridi:main Apr 13, 2024
4 checks passed
@luisalves00
Copy link
Author

Great, I didn't check Maven, since I don't use it that often anymore. I was assuming since it's calling the existing code it would also work fine. I have no clue how to automate test on a IntelliJ plugin.
When looking in a way to implement it I found your bug report and that a solution was implemented.
Thanks for including the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format all files before commit
3 participants