Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the reserved 'main' entry for CSS #139

Closed
wants to merge 1 commit into from

Conversation

niieani
Copy link
Contributor

@niieani niieani commented Nov 22, 2016

Uses 'css' field instead.

Fix for #122.

@niieani
Copy link
Contributor Author

niieani commented Nov 22, 2016

See https://docs.npmjs.com/files/package.json#main for reference. main can only be a JavaScript file.

@lipis
Copy link
Owner

lipis commented Nov 22, 2016

It looks like you are right :) Thanks man..

@lipis
Copy link
Owner

lipis commented Nov 22, 2016

css or maybe put it in files instead.. where we could include all the source files?

@niieani
Copy link
Contributor Author

niieani commented Nov 22, 2016

files is not necessary, since NPM includes all files except for node_modules, or .gitignore. You don't actually need any field, but I saw some CSS packages using css (either bootstrap or awesome-font). It's not standardized though.

@lipis
Copy link
Owner

lipis commented Nov 22, 2016

then let's just remove it completely.. :)

@lipis
Copy link
Owner

lipis commented Feb 19, 2017

jsut remove this line.. if you are still around :)

niieani added a commit to niieani/bootstrap-social that referenced this pull request Feb 19, 2017
@niieani niieani closed this Feb 19, 2017
@niieani niieani deleted the patch-1 branch February 19, 2017 01:16
lipis pushed a commit that referenced this pull request Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants