Great Britain Flags #120

lipis · 2015-12-22T22:19:01Z

https://en.wikipedia.org/wiki/ISO_3166-2:GB

Fixes #112

lipis · 2015-12-22T22:22:59Z

What codes should we use for all these flags?

Jokero · 2015-12-22T23:56:19Z

Maybe country name?
flag-icon-scotland
flag-icon-england
flag-icon-wales
flag-icon-northern-ireland

Jokero · 2015-12-23T00:02:38Z

gb-eng, gb-nir, gb-sct, gb-wls are good. They all are from ISO 3166-2

houndci-bot · 2015-12-23T20:28:11Z

sass/flag-icon.scss

@@ -1,3 +1,4 @@
 @import 'variables';
 @import 'flag-icon-base';
 @import 'flag-icon-list';
+@import 'flag-icon-more';


Prefer double-quoted strings

lipis · 2015-12-23T20:30:09Z

@simonwielens, @Jokero are you guys fine with these flags?

Jokero · 2015-12-24T00:01:16Z

gb-eng, gb-sct, gb-wls are ok, but I'm not sure about Northern Ireland flag.

From Northern Ireland wiki:

The official flag is that of the state having sovereignty over the territory, i.e. the Union Flag.
...
The Ulster flag and the Cross of St Patrick have no official status and, under the Flags Regulations, are not permitted to be flown from Government Buildings

But from flag of Northern Ireland wiki:

The Saint Patrick's Saltire is sometimes used by the government to represent Northern Ireland alongside the other countries of the United Kingdom, and is the centrepiece of the badge of the Police Service of Northern Ireland.
The Ulster Banner remains in use by unionists, a number of sporting organisations in Northern Ireland and some local government authorities under Unionist control.

St Patrick's Saltire:

Ulster Banner:

I do not know which one to use. Maybe we add both flags?

lipis · 2015-12-24T00:07:50Z

that's one of the reasons that I didn't want to include extra flags for so long.. :/

Jokero · 2015-12-24T00:22:30Z

We can keep only the flags of Scotland, England and Wales. Because they are all countries and have official flag

Jokero · 2015-12-24T00:23:52Z

And GB-NIR is province (https://en.wikipedia.org/wiki/ISO_3166-2:GB)

lipis · 2015-12-25T21:01:44Z

Sounds like a good idea..

lipis · 2015-12-25T21:05:45Z

Should be fine now.. :)

Great Britain Flags

Jokero · 2015-12-25T22:51:44Z

Cool!) Thanks 👍 Publish please new version

lipis · 2015-12-25T23:01:29Z

Maybe I'll merge the #125 as well.. before publishing.. the most demanded flag so far :)

Jokero · 2015-12-25T23:03:50Z

It would be great)

lipis · 2015-12-25T23:05:32Z

Published :) should appear soon in your nearest shop..

jcdsr · 2016-05-10T11:31:40Z

Great! stuff. Thx. But the GB-NIR is not showing up on your css.

NIR Flag
https://en.wikipedia.org/wiki/File:Flag_of_Northern_Ireland.svg

This NIR flag has been used on football and other events.
http://www.irishfa.com/
http://www.uefa.com/uefaeuro/season=2016/teams/team=63/index.html

Jokero · 2016-05-10T11:36:13Z

@carlosdv4 I tried to investigate this early #120 (comment). NIR is not a country and it does not have own official flag

jcdsr · 2016-05-11T09:25:20Z

:D You can run into a lot of troubles by just mention "NIR is not a country and it does not have own official flag"

May not be totally official but to every NIR that's their flag.

Could you add that flag to your files, please. I'm sure you won't get that many request for NIR.

Regards.

lipis · 2016-05-11T09:54:48Z

:D You can run into a lot of troubles by just mention "NIR is not a country and it does not have own official flag"

What kind of troubles?! It's a free world man.. we can say and do whatever we want.. (at least in this part of the world..)

Could you add that flag to your files, please. I'm sure you won't get that many request for NIR.

Nope.. sorry.. maybe if I'll get too many requests I'll reconsider.. :)

Jokero · 2016-05-11T12:14:49Z

@carlosdv4 I don't know the real situation around Northern Ireland, I just use public resources to get information :) So you can take a look at this page https://www.iso.org/obp/ui/#iso:code:3166:GB and find "Northern Ireland". It's marked as "province". In context of ISO 3166-2 my phrase is correct, but there is another question: does this standard contain correct information? 😄 Anyway this question is not related to this repository

seanfoo · 2016-05-11T12:38:17Z

I will say that I'm using the flags in a sports-related setting and for the
purpose of soccer, NIR is a "country" that competes with other countries.
Regardless of that though you probably need to pick a standard and stick
with it as there are dozens of such gray areas all over the world. Kosovo,
South Sudan, Catalonia, Gibraltar, Jersey etc. I'd definitely look at the
standards out there as they've been dealing with these issues for a while
now.

BTW, great project. really love it.

sean

Sean Forman
Sports Reference LLC, President
http://www.sports-reference.com/

On Wed, May 11, 2016 at 5:54 AM, Lipis notifications@github.com wrote:

:D You can run into a lot of troubles by just mention "NIR is not a
country and it does not have own official flag"

What kind of troubles?! It's a free world man.. we can say and do whatever
we want.. (at least in this part of the world..)

Could you add that flag to your files, please. I'm sure you won't get that
many request for NIR.

Nope.. sorry.. maybe if I'll get too many requests I'll reconsider.. :)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#120 (comment)

jcdsr · 2016-05-11T13:14:48Z

Anyway if you don't want to do it, here is the solution for NIR flag your lazy...

https://github.com/carlosdv4/norther_ireland_flag_svg

Took me 5 min to do it.

lipis · 2016-05-11T14:09:21Z

Internet is a fun place..! Not sure why people are getting mad.. or think that I'm lazy or care so much for something that they didn't do or wanted to do anyway.. like I mentioned before @carlosdv4 we live in a free world and nobody is paying me for doing that.. so how can you even demand or assume that I'm lazy?! do you think that this project just appeared here?! wtf?

@seanfoo Yes.. that was the whole point.. that I sticked only to the official CIA listed recognised countries but eventually due to the large demand I added a few more in the #120.. and now the chaos!! I enjoy the ride anyway.. it's fun! Thanks for the support..

jakwo · 2016-05-18T05:53:03Z

@lipis First of all, thanks for your work!

I am writing a small app about the UEFA EURO2016, for which Northern Ireland qualified. So the flag is widley spread on every match schedule everywhere. No offense, just saiing :)

I am using @carlosdv4 flags for now.

lipis · 2016-05-18T06:00:12Z

@jakwo That's a good reason.. can you point me to one or two such websites..?!

jakwo · 2016-05-18T06:02:25Z

Well, the official UEFA website is probably a good starting point: http://www.uefa.com/uefaeuro/season=2016/teams/team=63/index.html

lipis · 2016-05-18T06:03:46Z

@jakwo Sold! Will do :)

jakwo · 2016-05-18T06:04:09Z

@lipis Thank you :)

lipis · 2016-05-18T06:14:35Z

There :)

jakwo · 2016-05-18T06:16:24Z

That was fast. Appreciate it!

lipis · 2016-05-18T06:18:52Z

If you publish your app.. feel free to come back to us to show off ;)

* master: Flag of Maldives (Fixes #171) bump version Remove unnecessary comma (#245) Version 2.3.0 (new) Flag of Northern Ireland (#120) Rename scss files (#232) Flag for Slovakia (Fixes #243) Installation

specify in the readme how to access these flags that have no ISO codes. I got the info looking at issue lipis#120.

lipis mentioned this pull request Dec 22, 2015

Individual UK flags #112

Closed

lipis closed this Dec 22, 2015

lipis reopened this Dec 22, 2015

houndci-bot reviewed Dec 23, 2015
View reviewed changes

lipis force-pushed the gb branch from 0a4285f to eea2f50 Compare December 25, 2015 21:02

Great Britain Flags

18ccaa9

lipis force-pushed the gb branch from eea2f50 to 18ccaa9 Compare December 25, 2015 21:05

lipis added a commit that referenced this pull request Dec 25, 2015

Merge pull request #120 from lipis/gb

abfb289

Great Britain Flags

lipis merged commit abfb289 into master Dec 25, 2015

lipis deleted the gb branch December 25, 2015 21:26

This was referenced May 9, 2016

Wales flag is missing? #238

Closed

Scotland flag? #239

Closed

Northern Ireland flag? #237

Closed

lipis added a commit that referenced this pull request May 18, 2016

(new) Flag of Northern Ireland (#120)

ba44a8a

monlouisj added a commit to monlouisj/flag-icon-css that referenced this pull request Jun 5, 2016

add info about UK indiviual flags

34be7b9

specify in the readme how to access these flags that have no ISO codes. I got the info looking at issue lipis#120.

monlouisj mentioned this pull request Jun 5, 2016

add info about UK indiviual flags #250

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Great Britain Flags #120

Great Britain Flags #120

lipis commented Dec 22, 2015

lipis commented Dec 22, 2015

Jokero commented Dec 22, 2015

Jokero commented Dec 23, 2015

houndci-bot Dec 23, 2015

houndci-bot Dec 23, 2015

lipis commented Dec 23, 2015

Jokero commented Dec 24, 2015

lipis commented Dec 24, 2015

Jokero commented Dec 24, 2015

Jokero commented Dec 24, 2015

lipis commented Dec 25, 2015

lipis commented Dec 25, 2015

Jokero commented Dec 25, 2015

lipis commented Dec 25, 2015

Jokero commented Dec 25, 2015

lipis commented Dec 25, 2015

jcdsr commented May 10, 2016 •

edited

Jokero commented May 10, 2016

jcdsr commented May 11, 2016 •

edited

lipis commented May 11, 2016

Jokero commented May 11, 2016

seanfoo commented May 11, 2016

jcdsr commented May 11, 2016

lipis commented May 11, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

Great Britain Flags #120

Great Britain Flags #120

Conversation

lipis commented Dec 22, 2015

lipis commented Dec 22, 2015

Jokero commented Dec 22, 2015

Jokero commented Dec 23, 2015

houndci-bot Dec 23, 2015

Choose a reason for hiding this comment

houndci-bot Dec 23, 2015

Choose a reason for hiding this comment

lipis commented Dec 23, 2015

Jokero commented Dec 24, 2015

lipis commented Dec 24, 2015

Jokero commented Dec 24, 2015

Jokero commented Dec 24, 2015

lipis commented Dec 25, 2015

lipis commented Dec 25, 2015

Jokero commented Dec 25, 2015

lipis commented Dec 25, 2015

Jokero commented Dec 25, 2015

lipis commented Dec 25, 2015

jcdsr commented May 10, 2016 • edited

Jokero commented May 10, 2016

jcdsr commented May 11, 2016 • edited

lipis commented May 11, 2016

Jokero commented May 11, 2016

seanfoo commented May 11, 2016

jcdsr commented May 11, 2016

lipis commented May 11, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jakwo commented May 18, 2016

lipis commented May 18, 2016

jcdsr commented May 10, 2016 •

edited

jcdsr commented May 11, 2016 •

edited