CMakeLists.txt: don't force SHARED when building the library #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the CMake documentation [1]: If no type is given explicitly the type is STATIC or SHARED based on whether the current value of the variable BUILD_SHARED_LIBS is ON. The CMakeLists.txt currently forces "SHARED", which prevents static-only builds from working. By removing this "SHARED" statement, we let CMake decide whether a static or shared library should be built, depending on the value of the standard variable BUILD_SHARED_LIBS. [1] https://cmake.org/cmake/help/v3.0/command/add_library.html Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CMake documentation [1]:
If no type is given explicitly the type is STATIC or SHARED based
on whether the current value of the variable BUILD_SHARED_LIBS is
ON.
The CMakeLists.txt currently forces "SHARED", which prevents
static-only builds from working. By removing this "SHARED" statement,
we let CMake decide whether a static or shared library should be
built, depending on the value of the standard variable
BUILD_SHARED_LIBS.
[1] https://cmake.org/cmake/help/v3.0/command/add_library.html
Signed-off-by: Thomas Petazzoni thomas.petazzoni@bootlin.com